feat: Add v1 schema types #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds compatibility for sharing data with Coder v1. Since the tables are the same, all CRUD operations should function as expected.
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
==========================================
- Coverage 71.58% 69.91% -1.68%
==========================================
Files 17 18 +1
Lines 1112 1130 +18
==========================================
- Hits 796 790 -6
- Misses 246 269 +23
- Partials 70 71 +1
Continue to review full report at Codecov.
|
bryphe-coder
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds compatibility for sharing data with Coder v1. Since the tables are the same, all CRUD operations should function as expected.
What if v1 changes a type?
We'll need to reflect the updated type with an optional migration in v2.
What happens when we want to refactor users in v2, but still need to support v1?
It's much easier to fork the logic once we have data, so these tables will match the schema of v1 while it exists.