8000 fix: retrieve all branches through pagination by nikaro · Pull Request #38 · beatlabs/delete-old-branches-action · GitHub
[go: up one dir, main page]

Skip to content

fix: retrieve all branches through pagination #38
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2023
Merged

fix: retrieve all branches through pagination #38

merged 1 commit into from
Oct 18, 2023

Conversation

nikaro
Copy link
Contributor
@nikaro nikaro commented Oct 18, 2023

Description

Currently, only the 30th first opened pull requests are fetched by the curl API call (docs). To avoid dealing with header links for pagination let's use the GitHub CLI (gh) with the --paginate flag.

And since it doesn't make sense to mix curl and gh api, lets replace all curl occurrences by the way.

Related Issues

Ø

@nikaro nikaro requested a review from siavashs as a code owner October 18, 2023 18:31
Copy link
Collaborator
@siavashs siavashs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@siavashs siavashs merged commit 3a54bdf into beatlabs:master Oct 18, 2023
@nikaro nikaro deleted the fix/github-api-pagination branch October 19, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0