10BC0 fix(eks): update aws-node-termination-handler chart version by wafuwafu13 · Pull Request #34218 · aws/aws-cdk · GitHub
[go: up one dir, main page]
Skip to content

fix(eks): update aws-node-termination-handler chart version #34218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2025
Merged

fix(eks): update aws-node-termination-handler chart version #34218

merged 3 commits into from
Apr 24, 2025

Conversation

wafuwafu13
Copy link
Contributor
@wafuwafu13 wafuwafu13 commented Apr 22, 2025 •
edited
Loading

Issue # (if applicable)

Closes #34217

Reason for this change

Description of changes

Update aws-node-termination-handler chart version

Describe any new or updated permissions being added

None

Description of how you validated changes

Pass unit/integration tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Apr 22, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team April 22, 2025 13:42
@github-actions github-actions bot added bug This issue is a bug. p2 labels Apr 22, 2025
wafuwafu13
wafuwafu13 commented Apr 22, 2025
View reviewed changes
.../aws-eks/test/integ.eks-cluster-ipv6.js.snapshot/aws-cdk-eks-cluster-ipv6-test.template.json
"Values": "{\"nodeSelector\":{\"lifecycle\":\"Ec2Spot\"}}",
"Namespace": "kube-system",
"Repository": "https://aws.github.io/eks-charts",
"Repository": "oci://public.ecr.aws/aws-ec2/helm/aws-node-termination-handler",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before: https://artifacthub.io/packages/helm/aws/aws-node-termination-handler/0.18.0
After: https://artifacthub.io/packages/helm/aws-node-termination-handler/aws-node-termination-handler

wafuwafu13
wafuwafu13 commented Apr 22, 2025
View reviewed changes
packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ.eks-cluster.ts
@@ -43,7 +43,7 @@ class EksClusterStack extends Stack {
vpcSubnets,
mastersRole,
defaultCapacity: 2,
...getClusterVersionConfig(this),
...getClusterVersionConfig(this, eks.KubernetesVersion.V1_32),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes sense to test V1_24 by default.
I plan to fix it in another pull request.

aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-eks/test/integ-tests-kubernetes-version.ts

Lines 22 to 23 in 58c2631

export function getClusterVersionConfig(scope: Construct, version?: eks.KubernetesVersion) {
const _version = version ?? eks.KubernetesVersion.V1_24;

@wafuwafu13 wafuwafu13 mentioned this pull request Apr 22, 2025
Closed
1 task
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 22, 2025
wafuwafu13
wafuwafu13 commented Apr 23, 2025
View reviewed changes
packages/aws-cdk-lib/aws-eks/lib/cluster.ts
@@ -1183,8 +1183,8 @@ abstract class ClusterBase extends Resource implements ICluster {
if (!this._spotInterruptHandler) {
this._spotInterruptHandler = this.addHelmChart('spot-interrupt-handler', {
chart: 'aws-node-termination-handler',
version: '0.18.0',
repository: 'https://aws.github.io/eks-charts',
version: '0.27.0',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are having a discussion now.
#34217 (comment)

QuantumNeuralCoder
QuantumNeuralCoder previously approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor
@QuantumNeuralCoder QuantumNeuralCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the versions. Noting the change in repository. Approving the fix.

packages/aws-cdk-lib/aws-eks/lib/cluster.ts
version: '0.18.0',
repository: 'https://aws.github.io/eks-charts',
version: '0.27.0',
repository: 'oci://public.ecr.aws/aws-ec2/helm/aws-node-termination-handler',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified the versions. Approving this.

@mergify Mergify
Copy link
Contributor
mergify bot commented Apr 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify Mergify
Copy link
Contributor
mergify bot commented Apr 24, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 24, 2025
@mergify Mergify
Copy link
Contributor
mergify bot commented Apr 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed QuantumNeuralCoder’s stale review April 24, 2025 16:24

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 07fee82
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 24, 2025
@mergify Mergify
Copy link
Contributor
mergify bot commented Apr 24, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3380742 into aws:main Apr 24, 2025
20 of 21 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@QuantumNeuralCoder QuantumNeuralCoder QuantumNeuralCoder approved these changes

Assignees
No one assigned
Labels
bug This issue is a bug. p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-eks: aws-node-termination-handler Chart Version is Outdated
3 participants
@wafuwafu13 @aws-cdk-automation @QuantumNeuralCoder
0