8000 fix: 'Need to perform AWS calls for account' when doing cross-account deployments by rix0rrr · Pull Request #31846 · aws/aws-cdk · GitHub
[go: up one dir, main page]
Skip to content

fix: 'Need to perform AWS calls for account' when doing cross-account deployments #31846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Oct 22, 2024
Merged

fix: 'Need to perform AWS calls for account' when doing cross-account deployments #31846

mergify merged 1 commit into from
Oct 22, 2024

Conversation

@rix0rrr
Copy link
Contributor
@rix0rrr rix0rrr commented Oct 22, 2024 •
edited by mrgrain
Loading

Fixes #31845

Manually verified that cross-account access is possible again. Will follow up with a PR for more tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team October 22, 2024 12:41
@aws-cdk-automation aws-cdk-automation requested a review from a team October 22, 2024 12:41
@github-actions github-actions bot added bug This issue is a bug. p2 labels Oct 22, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 22, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator
@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Oct 22, 2024
@rix0rrr rix0rrr force-pushed the huijbers/fix-cross-account branch from 7426997 to 01a73e8 Compare October 22, 2024 12:56
@mrgrain mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Oct 22, 2024
@aws-cdk-automation
Copy link
Collaborator
aws-cdk-automation commented Oct 22, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 01a73e8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mrgrain mrgrain added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Oct 22, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 22, 2024 15:03

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor
mergify bot commented Oct 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 595a422 into main Oct 22, 2024
@mergify mergify bot deleted the huijbers/fix-cross-account branch October 22, 2024 15:04
@github-actions
Copy link
Contributor
github-actions bot commented Oct 22, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
< 7F15 /form>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

bug This issue is a bug. contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

❗NOTICE: Cross-account deployments are failing in v2.163.0 with error 'Need to perform AWS calls for account'

3 participants

@rix0rrr @aws-cdk-automation @mrgrain
0