[flake8_async] Fix sleep argument name for anyio (ASYNC115, ASYNC116)
#18262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind filling in the summary and test plan section of your PR? It would help us review your change |
|
Apologies for the delay — I got caught up with work and wasn’t able to write the tests or summary yet. I’ll update it shortly. |
MichaReiser
requested changes
May 25, 2025
There was a problem hiding this comment.
Thanks and also thank you for updating the summary. It helped me a lot to this PR a lot!
I think we should change the added tests because they currently wouldn't catch a regression (they're all okay). I think it's as easy as changing the argument provided to sleep/delay to 0 (which makes the rule trigger).
|
done @MichaReiser thank you very much for the review, have updated the tests. |
MichaReiser
approved these changes
May 26, 2025
|
flake8_async] Fix sleep argument name for anyio (ASYNC115, ASYNC116)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18164
Summary
Fix incorrect argument name detection for
anyio.sleepandtrio.sleepin ASYNC115 lint check.The linter previously assumed the keyword argument for sleep duration was always
seconds, causing false positives whendelaywas used withanyio.sleep.This update correctly distinguishes between
seconds(Trio) anddelay(AnyIO), improving accuracy.Fixes #18164
Test Plan
anyio.sleep(delay=0)andtrio.sleep(seconds=0)usage.