8000 [MARTIFACT-81] add reproducible-central report by hboutemy · Pull Request #73 · apache/maven-artifact-plugin · GitHub
[go: up one dir, main page]
Skip to content

[MARTIFACT-81] add reproducible-central report #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 5, 2025
Merged

[MARTIFACT-81] add reproducible-central report #73

merged 8 commits into from
Jan 5, 2025

Conversation

hboutemy
Copy link
Member
@hboutemy hboutemy commented Nov 22, 2024 •
edited
Loading

@hboutemy hboutemy marked this pull request as draft November 22, 2024 06:59
@hboutemy hboutemy self-assigned this Nov 22, 2024
slawekjaranowski
slawekjaranowski reviewed Nov 22, 2024
View reviewed changes
pom.xml
@@ -62,6 +62,7 @@
<properties>
<mavenVersion>3.9.6</mavenVersion>
<resolverVersion>1.9.20</resolverVersion>
<doxiaVersion>1.12.0</doxiaVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not doxia 2.x?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question...
compatibility with Maven Site Plugin 3?
I confess I was focused on the proof of concept badge-aspect, doing any choice that I knew would not hurt because good old known recipe: but yes, this is definitively a choice to be done before merging this currently still draft PR

@hboutemy
Copy link
Member Author

badge service PR proposed to img.shields.io badges/shields#10705
this approach brings better results on 404 = when a gav has not been rebuilt, then badge endpoint could just report that no badge was available
with the service, we can differentiate:

  • missing version from a known ga
  • fully missing ga => orange badge "unknown ga"
  • even SNAPSHOT version: checking reproducibility is not yet relevant

@hboutemy hboutemy force-pushed the MARTIFACT-81 branch 4 times, most recently from c5924c4 to 8dc9743 Compare December 11, 2024 22:58
@hboutemy hboutemy marked this pull request as ready for review December 31, 2024 15:23
@hboutemy hboutemy merged commit b82943b into master Jan 5, 2025
51 checks passed
@hboutemy hboutemy deleted the MARTIFACT-81 branch January 5, 2025 07:31
@jira-importer
Copy link

Resolve #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski left review comments

Assignees

@hboutemy hboutemy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hboutemy @jira-importer @slawekjaranowski
0