10000 fix(core): call DestroyRef on destroy callback if view is destroyed [patch] by arturovt · Pull Request #61061 · angular/angular · GitHub
[go: up one dir, main page]
Skip to content

fix(core): call DestroyRef on destroy callback if view is destroyed [patch] #61061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(core): call DestroyRef on destroy callback if view is destroyed [patch] #61061

wants to merge 1 commit into from
+69 −23

Conversation

arturovt
Copy link
Contributor

Patch version of 5f7f046

@pullapprove pullapprove bot requested a review from alxhub April 30, 2025 14:10
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Apr 30, 2025
@ngbot ngbot bot added this to the Backlog milestone Apr 30, 2025
@JeanMeche JeanMeche requested review from thePunderWoman and removed request for alxhub April 30, 2025 14:37
thePunderWoman
thePunderWoman approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor
@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 30, 2025
@mmalerba
Copy link
Contributor

This PR was merged into the repository by commit dbb8702.

The changes were merged into the following branches: 19.2.x

mmalerba pushed a commit that referenced this pull request Apr 30, 2025
@arturovt @mmalerba
fix(core): call DestroyRef on destroy callback if view is destroyed […
dbb8702 
…patch] (#61061)

Patch version of 5f7f046

PR Close #61061
@mmalerba mmalerba closed this Apr 30, 2025
@arturovt arturovt deleted the fix/patch_54527 branch April 30, 2025 15:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@arturovt @mmalerba @thePunderWoman
0