fix(core): do not activate event replay when no events are registered#56509
Closed
AndrewKushnir wants to merge 2 commits intoangular:mainfrom
Closed
fix(core): do not activate event replay when no events are registered#56509AndrewKushnir wants to merge 2 commits intoangular:mainfrom
AndrewKushnir wants to merge 2 commits intoangular:mainfrom
Conversation
iteriani
approved these changes
Jun 19, 2024
AndrewKushnir
commented
Jun 19, 2024
a09934a to
7ff425c
Compare
This commit adds extra checks to handle a situation when an application has no events configured, but the Event Replay feature was enabled. This situation can happen when some routes in an application are mostly static, when other routes are more interactive. Resolves angular#56423.
This commit adds a standard performance marker that can be viewed in Chrome dev tools and other tooling. See more info at https://developer.mozilla.org/en-US/docs/Web/API/Performance/mark
8000
AndrewKushnir
force-pushed
the
event_replay_fix_56423
branch
from
June 19, 2024 01:50
7ff425c to
27bc446
Compare
iteriani
approved these changes
Jun 19, 2024
Contributor
Author
Contributor
Author
|
Caretaker note: current approvals should be enough to proceed with the merge. |
Contributor
Author
|
This PR was merged into the repository by commit e20c6df. The changes were merged into the following branches: main, 18.0.x |
AndrewKushnir
added a commit
that referenced
this pull request
Jun 20, 2024
This commit adds a standard performance marker that can be viewed in Chrome dev tools and other tooling. See more info at https://developer.mozilla.org/en-US/docs/Web/API/Performance/mark PR Close #56509
AndrewKushnir
added a commit
that referenced
this pull request
Jun 20, 2024
…#56509) This commit adds extra checks to handle a situation when an application has no events configured, but the Event Replay feature was enabled. This situation can happen when some routes in an application are mostly static, when other routes are more interactive. Resolves #56423. PR Close #56509
AndrewKushnir
added a commit
that referenced
this pull request
Jun 20, 2024
This commit adds a standard performance marker that can be viewed in Chrome dev tools and other tooling. See more info at https://developer.mozilla.org/en-US/docs/Web/API/Performance/mark PR Close #56509
This was referenced Jul 12, 2024
This was referenced Jul 14, 2024
This was referenced Jul 15, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds extra checks to handle a situation when an application has no events configured, but the Event Replay feature was enabled. This situation can happen when some routes in an application are mostly static, when other routes are more interactive.
Resolves #56423.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?