10000 feat: add environmentEnabled property on feature defs by sighphyre · Pull Request #295 · Unleash/unleash-client-java · GitHub
[go: up one dir, main page]
Skip to content

feat: add environmentEnabled property on feature defs #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2025
Merged

feat: add environmentEnabled property on feature defs #295

merged 1 commit into from
Mar 12, 2025

Conversation

sighphyre
Copy link
Member

Restores the old enabled property on feature defs. I've chosen to rename this to environmentEnabled, which I think expresses better what this actually means

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 79.616% (+0.2%) from 79.439%
when pulling 934f48a on feat/restore-enabled-property-on-feature-defs
into 9734138 on main.

@chriswk chriswk moved this from New to In Progress in Issues and PRs Mar 12, 2025
@chriswk chriswk self-requested a review March 12, 2025 08:32
chriswk
chriswk approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member
@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LRTM :)

@github-project-automation github-project-automation bot moved this from In Progress to Approved PRs in Issues and PRs Mar 12, 2025
@sighphyre sighphyre merged commit d0327ba into main Mar 12, 2025
11 checks passed
@sighphyre sighphyre deleted the feat/restore-enabled-property-on-feature-defs branch March 12, 2025 08:51
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in Issues and PRs Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriswk chriswk chriswk approved these changes

Assignees

@sighphyre sighphyre

Labels
None yet
Projects
Issues and PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sighphyre @coveralls @chriswk
0