[go: up one dir, main page]

Page MenuHomePhabricator

MWExceptionRenderer's error box is supposed to be LTR in RTL user interface but isn't
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Ebrahim
Aug 5 2024, 12:27 PM
Referenced Files
F57069024: image.png
Aug 5 2024, 12:27 PM
F57069008: image.png
Aug 5 2024, 12:27 PM
F57069000: image.png
Aug 5 2024, 12:27 PM
F57068971: image.png
Aug 5 2024, 12:27 PM

Description

Steps to replicate the issue (include links if applicable):

image.png (620×2 px, 139 KB)

  • Use an RTL language like Persian for the interface or append ?uselang=fa

What happens?:
English text but in RTL

image.png (682×2 px, 180 KB)

What should have happened instead?:
LTR content

image.png (708×2 px, 197 KB)

Software version: 6724bb6a90076d7423c29dc4a2827b2ef27d60a3

If shouldShowExceptionDetails is disabled currently it shows the following despite having mw-content-ltr

image.png (546×2 px, 108 KB)

Which as it has an RTL text it's shouldn't be LTR so the patch actually removes mw-content-ltr at least in vector-2022 where mw-content-{ltr,rtl} are no effect as T287701 which even if it had any effect it wasn't needed.

Patch is coming

Event Timeline

Ebrahim renamed this task from MWExceptionRenderer's error box is supposed to be LTR in RTL but isn't to MWExceptionRenderer's error box is supposed to be LTR in RTL user interface but isn't.Aug 5 2024, 12:27 PM

Change #1059878 had a related patch set uploaded (by Ebrahim; author: Ebrahim):

[mediawiki/core@master] Make error box content LTR for exceptions details

https://gerrit.wikimedia.org/r/1059878

Ebrahim updated the task description. (Show Details)
Ebrahim added a subscriber: matmarex.

This is unintentionally related to T371265 also, though, I didn't have plan to go for this and I just happened to see it due to a local misconfiguration.

This was previously fixed in T153027, but that fix no longer works as a result of T287701.

Change #1059878 merged by jenkins-bot:

[mediawiki/core@master] Make error box content LTR for exceptions details

https://gerrit.wikimedia.org/r/1059878