[go: up one dir, main page]

Page MenuHomePhabricator

Add support for the showSymbols chart definition option
Closed, ResolvedPublic

Description

Acceptance Criteria:

  • When showSymbols = false, the line chart does not show symbols (circles) for each data point
  • When showSymbols = true, the line chart shows symbols (circles) for each data point
  • If showSymbols is omitted from the chart definition, then do not show symbols (as the default)

The Graph lua module also allowed showSymbols to be an array of numbers, representing symbol size of each data point. TBD how we want to handle symbol size options.

If showSymbols is invalid, then do not show symbols. (the default) TBD how we want to handle this type of validation.

Event Timeline

Change #1059469 had a related patch set uploaded (by Aude; author: Aude):

[mediawiki/extensions/Chart@master] Support showSymbols chart definition option

https://gerrit.wikimedia.org/r/1059469

@aude

The Graph lua module also allowed showSymbols to be an array of numbers, representing symbol size of each data point

This option was introduced to be able to define separate size of symbol for each of data series (not each data point).
Additionally for each data series it was possible defined linewidth and symbol shape (same way as for symbol size).
All those features seems to be possible in eChart. Please see my example here.

Please also see graph template examples on beta cluster in template documentation page, template test page and this example . Graph extension still works there, Vega library was there updated to v5.* and also graph module.

Change #1059469 merged by jenkins-bot:

[mediawiki/extensions/Chart@master] Support showSymbols chart definition option

https://gerrit.wikimedia.org/r/1059469

@Pietrasagh For the initial demo, we are limiting showSymbols to true and false, but will consider if/how we can support the other options for symbol size, line width etc.

aude claimed this task.