[go: up one dir, main page]

Page MenuHomePhabricator

MPIC: Update unit test cases
Closed, ResolvedPublic1 Estimated Story Points

Description

Description

At some point we created some unit test cases to cover some basic MPIC functionality but, right now, some of them are a bit outdated because we have been working on some changes but unit test cases haven't been updated according to those ones.

For example, there are new fields to define an instrument so this data should be added to the mock data we use to prepare unit test cases for registering/updating an instrument. This data is also included in the response for other operations like the ones we use to get all instruments.

There are also new features like instruments deletion and enablement/disablement that should be added.

Acceptance criteria

  • Existing unit test cases have been updated
  • New cases has been added according to the new features

Event Timeline

Sfaci set the point value for this task to 1.

There is a MR ready for review where existing unit test cases have been updated and also others have been added to cover new functionality: https://gitlab.wikimedia.org/repos/data-engineering/mpic/-/merge_requests/86

Change #1062101 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploy to staging

https://gerrit.wikimedia.org/r/1062101

Change #1062101 merged by jenkins-bot:

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploy to staging

https://gerrit.wikimedia.org/r/1062101

Change #1062105 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploy to production

https://gerrit.wikimedia.org/r/1062105

Change #1062105 merged by jenkins-bot:

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploy to production

https://gerrit.wikimedia.org/r/1062105