Make chart cli script as a wrapper around node service endpoint
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	aude
	Jul 24 2024, 11:44 PM

Description

Acceptance Criteria:

We should make the chart cli script be a wrapper around node service endpoint, instead of duplicating code.

There would be a configuration to specify the service endpoint that the extension would use.

Notes:

This builds on these tickets:

https://phabricator.wikimedia.org/T369681

https://phabricator.wikimedia.org/T370975

Details

	Subject	Repo	Branch	Lines +/-
	Use either service or CLI depending on config	mediawiki/extensions/Chart	master	+137 -52

Customize query in gerrit

Related Objects

Mentioned In: rECRT05d655a5e233: Use either service or CLI depending on config
Mentioned Here: T369681: Build simple CLI script for rendering charts
T370975: Implement basic chart rendering node service

Event Timeline

aude created this task.Jul 24 2024, 11:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2024, 11:44 PM

aude updated the task description. (Show Details)Jul 24 2024, 11:45 PM

aude updated the task description. (Show Details)

• Catrope triaged this task as Medium priority.Mon, Aug 12, 6:39 PM

• Catrope set the point value for this task to 3.

• Catrope moved this task from Needs Triage to Estimated on the Charts board.

• Catrope moved this task from Estimated to Sprint 4 on the Charts board.

• Catrope edited projects, added Charts (Sprint 4); removed Charts.

• Catrope moved this task from Incoming to Blocked on the Charts (Sprint 4) board.Mon, Aug 12, 6:44 PM

Jdlrobson subscribed.Thu, Aug 15, 8:50 PM

• Catrope moved this task from Blocked to Ready for Dev on the Charts (Sprint 4) board.Mon, Aug 19, 6:40 PM

• Catrope claimed this task.Mon, Aug 19, 6:43 PM

catrope opened https://gitlab.wikimedia.org/repos/mediawiki/services/chart-renderer/-/merge_requests/10

Add CLI wrapper

Change #1064064 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/extensions/Chart@master] Use either service or CLI depending on config

https://gerrit.wikimedia.org/r/1064064

• Catrope moved this task from Ready for Dev to Code Review on the Charts (Sprint 4) board.Thu, Aug 22, 7:56 PM

aude merged https://gitlab.wikimedia.org/repos/mediawiki/services/chart-renderer/-/merge_requests/10

Add CLI wrapper

Change #1064064 merged by jenkins-bot:

[mediawiki/extensions/Chart@master] Use either service or CLI depending on config

https://gerrit.wikimedia.org/r/1064064

• Catrope mentioned this in rECRT05d655a5e233: Use either service or CLI depending on config.Sat, Aug 24, 12:26 AM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.20; 2024-08-27).Sat, Aug 24, 1:00 AM

• Catrope closed this task as Resolved.Mon, Aug 26, 6:14 PM

• Catrope moved this task from Sprint 4 to Backlog on the Charts board.

• Catrope edited projects, added Charts; removed Charts (Sprint 4).

• Catrope moved this task from Backlog to Sprint 4 on the Charts board.