[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T369502

MPIC: Add log messages to service layer
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Description

At this time controller layer is logging any error/warning/success case properly and returning an appropriate response.

But the service layer, that has a deeper detail of what's being executed, is not logging too much and some errors or warnings are only shown through the frontend layer with less details than desired in the case we need debug something.

In order to be able to debug properly while dogfooding or testing MPIC we should log any success/warning/success case at service layer.

Acceptance criteria

  • We log any error/warning/success at service layer
  • We log any error/warning/success for actionApi.js
  • We log any error/warning/success for nocApi.js

Details

SubjectRepoBranchLines +/-
Metrics Platform Instrument Configuration: Deploy v0.1.0 to productionoperations/deployment-chartsmaster+1 -1
Metrics Platform Instrument Configuration: Deploy v0.1.0 to stagingoperations/deployment-chartsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Sfaci created this task.Jul 8 2024, 1:07 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2024, 1:07 PM
Sfaci moved this task from Sprint Backlog to In Process on the Data Products (Data Products Sprint 16) board.Jul 8 2024, 1:08 PM
Sfaci mentioned this in T368801: [EPIC] MPIC: Fix outstanding issues.
Sfaci renamed this task from MPIC: Add log messages when service layer throws an exception to MPIC: Add log messages to service layer.Jul 8 2024, 1:27 PM
Sfaci set the point value for this task to 1.Jul 8 2024, 6:16 PM
Sfaci moved this task from In Process to Code Review / Tech Input on the Data Products (Data Products Sprint 16) board.Jul 9 2024, 6:47 PM
Sfaci added a comment.Jul 9 2024, 7:01 PM

A MR is ready for review: https://gitlab.wikimedia.org/repos/data-engineering/mpic/-/merge_requests/75

Sfaci moved this task from Code Review / Tech Input to To Deploy on the Data Products (Data Products Sprint 16) board.Jul 9 2024, 8:05 PM
gerritbot added a comment.Jul 10 2024, 3:41 PM

Change #1053339 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploy v0.1.0 to staging

https://gerrit.wikimedia.org/r/1053339

gerritbot added a project: Patch-For-Review.Jul 10 2024, 3:41 PM
gerritbot added a comment.Jul 10 2024, 3:46 PM

Change #1053339 merged by jenkins-bot:

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploy v0.1.0 to staging

https://gerrit.wikimedia.org/r/1053339

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2024, 4:31 PM
gerritbot added a comment.Jul 10 2024, 4:35 PM

Change #1053350 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploy v0.1.0 to production

https://gerrit.wikimedia.org/r/1053350

gerritbot added a project: Patch-For-Review.Jul 10 2024, 4:35 PM
gerritbot added a comment.Jul 10 2024, 5:03 PM

Change #1053350 merged by jenkins-bot:

[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploy v0.1.0 to production

https://gerrit.wikimedia.org/r/1053350

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2024, 5:31 PM
Sfaci moved this task from To Deploy to Done on the Data Products (Data Products Sprint 16) board.Jul 10 2024, 7:12 PM
WDoranWMF closed this task as Resolved.Fri, Aug 16, 4:34 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits