Description
Details
Related Objects
Event Timeline
How should we determine the progress? only based on time? I mean considering the start/end time and the current one we could calculate how the instrument has progressed (showing the percentage value)
As we have discussed in a slack thread, time based percentages is the way we have to implement this.
Hi @VirginiaPoundstone! @cjming and I have been discussing about where/how we should calculate the progress for a specific instrument. There are two approaches:
- We can consider progress as a new instrument field and calculate it automatically when needed at the backend to include it in the response to be rendered in the frontend and, that way, it could be used by the extension to consider that an instrument is already done (100% progress would be the same as status = Off). The idea behind this is that the extension doesn't consider automatically any instrument that have already finished based on the endDate regardless the current status (status must be changed manually by someone). Are we interested on that approach?
- On the other hand, we can just consider progress as something that we can calculate in the frontend to only offer that information to the users
Great question @Sfaci. My gut is telling me server-side so it solves the automatic turn off you mention. Maybe it is also somehow useful in data QA. I especially like that it does not give user false indicators if in fact something has gone wrong and the data collection has stopped or is not active for some other reason.
CC @cming and @mwilliams
A MR is ready for review with progress as a new server side field that is rendered as a % value in the frontend side and is served as a value from 0 to 1 in the API response: https://gitlab.wikimedia.org/repos/data-engineering/mpic/-/merge_requests/82
Change #1057235 had a related patch set uploaded (by Clare Ming; author: Clare Ming):
[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploying to staging
Change #1057235 merged by jenkins-bot:
[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploying to staging
Change #1057242 had a related patch set uploaded (by Clare Ming; author: Clare Ming):
[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploying to production
Change #1057242 merged by jenkins-bot:
[operations/deployment-charts@master] Metrics Platform Instrument Configuration: Deploying to production