Dark mode shouldn't apply when printing page (mobile and desktop)
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	May 31 2024, 3:35 PM

Description

Steps to replicate the issue (include links if applicable):

Visit https://en.wikipedia.org/wiki/Clayton_Park_West_(electoral_district)?vectornightmode=1 or https://en.m.wikipedia.org/wiki/Clayton_Park_West_(electoral_district)?minervanightmode=1
Switch to dark mode
Click print

(Repeat on mobile)

What happens?:

Screenshot 2024-05-31 at 8.36.28 AM.png (1×2 px, 532 KB)

What should have happened instead?:

Black text on white background - as if dark mode is disabled.
Fix should apply to both mobile and desktop themes

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Probably can be fixed by applying the same rules in notheme to html using @print media query

QA Results - Beta

AC	Status	Details
1	❓	T366362#9951772

Sign off steps

Follow up on T366362#9957385 before resolving this ticket creating a new ticket.

T369874

Details

Subject	Repo	Branch	Lines +/-
Disable night mode while printing and re-enable afterwards	mediawiki/core	master	+14 -0
Force light theme in print styles	mediawiki/skins/MinervaNeue	master	+19 -17
Force light theme in print styles, remove unnecessary css variables	mediawiki/skins/Vector	master	+88 -91

Customize query in gerrit

Related Objects

Mentioned In: T371331: Dark mode styles leak into printed media
T369874: [Spike 1day] Many template styles are following outdated instructions that we gave them and need fixing
T368687: Verify 1.43.0-wmf.13 deployment
T363780: [QA] Exploratory testing: Vector 2022 night theme
Mentioned Here: T369874: [Spike 1day] Many template styles are following outdated instructions that we gave them and need fixing

Event Timeline

Jdlrobson created this task.May 31 2024, 3:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2024, 3:35 PM

Jdlrobson triaged this task as Medium priority.May 31 2024, 3:35 PM

Jdlrobson added a project: FY2023-24-WE 2.1 Typography and palette customizations.

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog board.

Jdlrobson mentioned this in T363780: [QA] Exploratory testing: Vector 2022 night theme.May 31 2024, 3:37 PM

Jdlrobson moved this task from Backlog to Dark mode on the FY2023-24-WE 2.1 Typography and palette customizations board.May 31 2024, 4:47 PM

• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:39 AM

JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:44 AM

Jdlrobson edited projects, added Web-Team-Backlog (FY2024-25 Q1 Sprint 1), dark-mode, patch-welcome; removed Web-Team-Backlog.Jun 28 2024, 2:58 AM

Jdlrobson moved this task from Backlog to Web (MediaWiki) on the dark-mode board.Jun 28 2024, 3:03 AM

Jdlrobson raised the priority of this task from Medium to High.Jun 28 2024, 8:08 PM

Jdlrobson moved this task from Needs analysis to Ready for estimation on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

Change #1050705 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/core@master] Disable night mode while printing and re-enable afterwards

https://gerrit.wikimedia.org/r/1050705

gerritbot added a project: Patch-For-Review.Jun 29 2024, 12:24 PM

TheDJ attached a referenced file: F54692474: screenshot 456.png. (Show Details)Jun 29 2024, 12:25 PM

This method won't work without JS enabled, but it is a quick and dirty and cross skin way that might be easier to deploy short term, than @media print notheme.

Jdlrobson renamed this task from Dark mode shouldn't apply when printing page to Dark mode shouldn't apply when printing page (mobile and desktop).Jul 1 2024, 4:15 PM

Jdlrobson updated the task description. (Show Details)

ovasileva set the point value for this task to 2.Jul 1 2024, 5:56 PM

ovasileva moved this task from Ready for estimation to Ready for Development on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

Change #1051212 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Force light theme in print styles

https://gerrit.wikimedia.org/r/1051212

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1050705

bwang claimed this task.Jul 2 2024, 3:22 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

Change #1051425 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Force light theme in print styles, remove unnecessary css variables

https://gerrit.wikimedia.org/r/1051425

bwang removed bwang as the assignee of this task.Jul 2 2024, 5:40 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

bwang subscribed.

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.Jul 3 2024, 12:44 AM

Note that if we go with:
@media screen and ( prefers-color-scheme: dark ) { we also need to correct all other usages of skin-theme-clientpref-os that have recently been added on the wikis etc. and the documentation.

Jdlrobson awarded a token.Jul 3 2024, 7:16 PM

Change #1051425 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Force light theme in print styles, remove unnecessary css variables

https://gerrit.wikimedia.org/r/1051425

Change #1051212 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Force light theme in print styles

https://gerrit.wikimedia.org/r/1051212

Jdlrobson assigned this task to GMikesell-WMF.Jul 3 2024, 7:52 PM

Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 3 2024, 8:00 PM

@Jdlrobson Please review the possible issue below. If that is fine, you can move this to sign-off, thanks!

Test Result - Beta

Status: ❓NMI
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Desktop	Mobile

❓Possible Issue

Desktop the linked words are underline and black but on mobile they are light grey

Desktop	Mobile

GMikesell-WMF updated the task description. (Show Details)Jul 3 2024, 9:07 PM

LGTM!

Jdlrobson reassigned this task from GMikesell-WMF to ovasileva.Jul 3 2024, 10:37 PM

Jdlrobson added a subscriber: GMikesell-WMF.

@Jdlrobson So are we updating all our previous deployed overrides and the documentation to match this, as I pointed out in T366362#9948098 ?

Hey @TheDJ yes. I've updated the documentation now and I need to create a ticket for working out what to do with the existing code before signing off. I'll add this to the sign off steps.

https://global-search.toolforge.org/?q=%5C%40media+%3F%5C%28+%3Fprefers-color-scheme%3A+dark&regex=1&namespaces=&title= ( 859 results)

FWIW I do think there is an argument to be made here that TemplateStyles should support a media parameter and default to @screen when not given given the low usage of print styles (but likely out of scope here):
https://global-search.toolforge.org/?q=%5C%40media+print&regex=1&namespaces=10%2C828&title=

Jdlrobson updated the task description. (Show Details)Jul 5 2024, 6:08 PM

ovasileva reassigned this task from ovasileva to Jdlrobson.Jul 8 2024, 5:34 PM

ovasileva subscribed.

GMikesell-WMF mentioned this in T368687: Verify 1.43.0-wmf.13 deployment.Jul 11 2024, 5:13 PM

I've proposed T369874 for fixing the existing template usages.

Jdlrobson updated the task description. (Show Details)Jul 11 2024, 10:12 PM

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Visit https://en.wikipedia.org/wiki/California and https://en.m.wikipedia.org/wiki/California
Switch to dark mode
Click print

Desktop	Mobile

Change #1050705 abandoned by TheDJ:

[mediawiki/core@master] Disable night mode while printing and re-enable afterwards

Reason:

alternative solution was chosen

https://gerrit.wikimedia.org/r/1050705

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2024, 9:31 PM

Jdlrobson mentioned this in T371331: Dark mode styles leak into printed media.Jul 29 2024, 9:39 PM

	F54798515: Screenshot 2024-05-31 at 8.36.28 AM.png
	May 31 2024, 3:36 PM

	F56147446: printit.gif
	Jul 1 2024, 10:17 PM

Dark mode shouldn't apply when printing page (mobile and desktop)Closed, ResolvedPublic2 Estimated Story PointsBUG REPORTActions

Description

QA Results - Beta

Sign off steps

Details

Related Objects

Event Timeline

Test Result - Beta

Test Steps

Test Result - PROD

Test Steps

Dark mode shouldn't apply when printing page (mobile and desktop)
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions