[go: up one dir, main page]

Page MenuHomePhabricator

Language button appears in 3 colors in dark mode
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

screenshot 421.png (1×1 px, 543 KB)

What should have happened instead?:
Consistent colors

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Likely due to the invert on the icons. Will hopefully be fixed when we transition to Codex icons.

Requirement

Ensure that the language button in dark mode has a consistent color in the Vector 2022 skin, making it visually accessible and matching the design specifications.

BDD

Feature: Consistent Color for Language Button in Dark Mode

  Scenario: Ensure language button color consistency in dark mode
    Given the user has enabled dark mode in Vector 2022
    When the user views the language button
    Then the language button should have a consistent color
    And the color should match the design specifications

Test Steps

Test Case 1: Ensure Language Button Color Consistency in Dark Mode

  1. Enable dark mode in the Vector 2022 skin.
  2. Navigate to this test page on testwiki or this page on betawiki.
  3. Verify the color of the language button.
  4. AC1: Confirm that the language button has a consistent color in dark mode and matches the design specifications.

QA Results - Beta

ACStatusDetails
1T366337#9873552

QA Results - PROD

ACStatusDetails
1T366337#9893743

Sign off

Event Timeline

This should be addressed by T363920. We are playing whack-a-mole until then.

Change #1038910 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Use mask-image for all Vector icons

https://gerrit.wikimedia.org/r/1038910

Change #1039318 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Follow-up to Id04e39 "Adds invert exception for dropdown"

https://gerrit.wikimedia.org/r/1039318

Change #1039318 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Follow-up to Id04e39 "Adds invert exception for dropdown"

https://gerrit.wikimedia.org/r/1039318

Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 1.

After Jan's change this is how it now looks:

Screenshot 2024-06-06 at 1.56.23 PM.png (148×440 px, 11 KB)

The long term solution is to do T364119

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Language Button Color Consistency in Dark Mode

  1. Enable dark mode in the Vector 2022 skin.
  2. Navigate to this test page on testwiki or this page on betawiki.
  3. Verify the color of the language button.
  4. AC1: Confirm that the language button has a consistent color in dark mode and matches the design specifications.

screenshot 601.png (902×1 px, 280 KB)

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Language Button Color Consistency in Dark Mode

  1. Enable dark mode in the Vector 2022 skin.
  2. Navigate to this test page on testwiki or this page on betawiki.
  3. Verify the color of the language button.
  4. AC1: Confirm that the language button has a consistent color in dark mode and matches the design specifications.

2024-06-14_09-36-20.png (707×3 px, 460 KB)

Change #1038910 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] POC: Use mask-image for all Vector icons

Reason:

To be discussed with DST on Tuesday June 18th

https://gerrit.wikimedia.org/r/1038910

Change #1038910 restored by Jdlrobson:

[mediawiki/skins/Vector@master] POC: Use mask-image for all Vector icons

https://gerrit.wikimedia.org/r/1038910