- Open VE and choose Insert->Media
- Search for "cat" and click the first result:
Observed | Expected |
Esanders | |
May 2 2024, 11:38 AM |
F53233721: Screenshot 2024-05-14 at 23.25.46.png | |
May 14 2024, 10:26 PM |
F53208822: Screenshot 2024-05-14 at 18.01.13.png | |
May 14 2024, 5:04 PM |
F50970774: Screenshot 2024-05-08 at 11.47.40.png | |
May 10 2024, 6:08 PM |
F50955703: Screenshot 2024-05-08 at 10.44.07.png | |
May 10 2024, 6:08 PM |
F50955732: Screenshot 2024-05-08 at 10.44.19.png | |
May 10 2024, 6:08 PM |
F50971053: Screenshot 2024-05-08 at 11.48.47.png | |
May 10 2024, 6:08 PM |
F49802773: image.png | |
May 2 2024, 11:38 AM |
F49802920: image.png | |
May 2 2024, 11:38 AM |
Observed | Expected |
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Fix media dialog layout. | mediawiki/extensions/VisualEditor | master | +4 -4 |
Change #1026652 had a related patch set uploaded (by Zoe; author: Zoe):
[mediawiki/extensions/VisualEditor@master] Fix media dialog layout.
Change #1026652 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix media dialog layout.
Insert Experience and Drag and drop shuffles between these experiences
However, images are broken
I'm having trouble reproing so I'm not sure how to proceed. I'll have another go in a couple days.
It breaks in Chrome and Firefox for me.
It works just fine in prod. If you can't reproduce the broken image, let's have someone else try. If it works fine for them, we can unblock it.
Thanks for double checking… I was hoping it would just be transient.
I don't see how my change could result in broken images, as it's a pure CSS change. Do you mind if I file that as a separate ticket?
The layout stuff needs further investigation. I notice from the metadata that the thinner images get metadata shown to the right but the wider ones get it below, so this may be behaving as intended. I'll go and have a dig through the code to see if that's on purpose and get back to you.
The broken images wasn't introduced by your change. I think the experience in my comment is expected. We can align with the team to confirm.
Test wiki created on Patch demo by Zoe-WMF using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/e858753122/w
It's just a beta issue – apparently nobody's actively maintaining it. I fired up a patchdemo and was able to upload an image just fine.