[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T343581

Special:Upload TypeError: Cannot read properties of undefined (reading 'isConnected')
Closed, ResolvedPublicBUG REPORT
Actions

Description

New error that began on August 3rd.
https://logstash.wikimedia.org/goto/0cfa5849080bf95b9114576a9ab74586
178 errors in last 24hrs

at https://commons.wikimedia.org/w/load.php?lang=deownwork&modules=ext.3d.special.upload%7Cext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.charinsert%2CeventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.echo.api%2Cinit%7Cext.tmh.OgvJsSupport%2Cplayer%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.specialPages%2Cwikibase%7Cjquery%2Coojs%2Csite%7Cjquery.client%2ClengthLimit%2Cspinner%2CtextSelection%7Cjquery.spinner.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cexperiments%2Chtmlform%2CjqueryMsg%2Clanguage%2Cspecial%2Cstorage%2Ctemplate%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.jpegmeta%2Cpluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.special.upload%7Cskins.vector.legacy.js&skin=vector&version=miz6t:531:1100
at Object.fire  https://commons.wikimedia.org/w/load.php?lang=deownwork&modules=ext.3d.special.upload%7Cext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.charinsert%2CeventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.echo.api%2Cinit%7Cext.tmh.OgvJsSupport%2Cplayer%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.specialPages%2Cwikibase%7Cjquery%2Coojs%2Csite%7Cjquery.client%2ClengthLimit%2Cspinner%2CtextSelection%7Cjquery.spinner.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cexperiments%2Chtmlform%2CjqueryMsg%2Clanguage%2Cspecial%2Cstorage%2Ctemplate%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.jpegmeta%2Cpluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.special.upload%7Cskins.vector.legacy.js&skin=vector&version=miz6t:413:816
at Object.setWarning  https://commons.wikimedia.org/w/load.php?lang=deownwork&modules=ext.3d.special.upload%7Cext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.charinsert%2CeventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.echo.api%2Cinit%7Cext.tmh.OgvJsSupport%2Cplayer%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.specialPages%2Cwikibase%7Cjquery%2Coojs%2Csite%7Cjquery.client%2ClengthLimit%2Cspinner%2CtextSelection%7Cjquery.spinner.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cexperiments%2Chtmlform%2CjqueryMsg%2Clanguage%2Cspecial%2Cstorage%2Ctemplate%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.jpegmeta%2Cpluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.special.upload%7Cskins.vector.legacy.js&skin=vector&version=miz6t:540:196
at https://commons.wikimedia.org/w/load.php?lang=deownwork&modules=ext.3d.special.upload%7Cext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.charinsert%2CeventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.echo.api%2Cinit%7Cext.tmh.OgvJsSupport%2Cplayer%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.specialPages%2Cwikibase%7Cjquery%2Coojs%2Csite%7Cjquery.client%2ClengthLimit%2Cspinner%2CtextSelection%7Cjquery.spinner.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cexperiments%2Chtmlform%2CjqueryMsg%2Clanguage%2Cspecial%2Cstorage%2Ctemplate%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.jpegmeta%2Cpluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.special.upload%7Cskins.vector.legacy.js&skin=vector&version=miz6t:540:1
at mightThrow  https://commons.wikimedia.org/w/load.php?lang=deownwork&modules=ext.3d.special.upload%7Cext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.charinsert%2CeventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.echo.api%2Cinit%7Cext.tmh.OgvJsSupport%2Cplayer%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.specialPages%2Cwikibase%7Cjquery%2Coojs%2Csite%7Cjquery.client%2ClengthLimit%2Cspinner%2CtextSelection%7Cjquery.spinner.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cexperiments%2Chtmlform%2CjqueryMsg%2Clanguage%2Cspecial%2Cstorage%2Ctemplate%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.jpegmeta%2Cpluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.special.upload%7Cskins.vector.legacy.js&skin=vector&version=miz6t:206:881
at process  https://commons.wikimedia.org/w/load.php?lang=deownwork&modules=ext.3d.special.upload%7Cext.centralNotice.geoIP%7Cext.centralauth.ForeignApi%7Cext.centralauth.centralautologin.clearcookie%7Cext.charinsert%2CeventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.echo.api%2Cinit%7Cext.tmh.OgvJsSupport%2Cplayer%7Cext.uls.common%2Ccompactlinks%2Cinterface%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.specialPages%2Cwikibase%7Cjquery%2Coojs%2Csite%7Cjquery.client%2ClengthLimit%2Cspinner%2CtextSelection%7Cjquery.spinner.styles%7Cjquery.uls.data%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cexperiments%2Chtmlform%2CjqueryMsg%2Clanguage%2Cspecial%2Cstorage%2Ctemplate%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.libs.jpegmeta%2Cpluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.special.upload%7Cskins.vector.legacy.js&skin=vector&version=miz6t:207:544

Details

SubjectRepoBranchLines +/-
Avoid errors when 'wikipage.content' hook fired with nothingmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Aug 4 2023, 6:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2023, 6:05 PM
Jdlrobson added subscribers: Fomafix, matmarex.Aug 4 2023, 6:06 PM
Umherirrender added subscribers: Esanders, Umherirrender.Aug 4 2023, 6:09 PM

Seems new code from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/816202

matmarex added a comment.Aug 10 2023, 8:17 PM

Apparently mediawiki.special.upload sometimes fires the hook on an empty jQuery collection. I guess it works with everything else…

matmarex claimed this task.Aug 10 2023, 8:19 PM
gerritbot added a comment.Aug 10 2023, 8:19 PM

Change 947938 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Avoid errors when 'wikipage.content' hook fired with nothing

https://gerrit.wikimedia.org/r/947938

gerritbot added a project: Patch-For-Review.Aug 10 2023, 8:19 PM
matmarex merged a task: T344023: JavaScript TypeError on Wikimedia Commons "Special:Upload" Page: "TypeError: $content[0] is undefined".Aug 10 2023, 9:19 PM
matmarex added subscribers: KSarabia-WMF, Masumrezarock100.
gerritbot added a comment.Aug 10 2023, 10:18 PM

Change 947938 merged by jenkins-bot:

[mediawiki/core@master] Avoid errors when 'wikipage.content' hook fired with nothing

https://gerrit.wikimedia.org/r/947938

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2023, 10:30 PM
matmarex closed this task as Resolved.Aug 10 2023, 10:49 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 10 2023, 11:00 PM
Esanders awarded a token.Aug 11 2023, 10:07 AM
Multichill mentioned this in T344207: Special:Upload redirects after loading.Aug 16 2023, 1:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits