[go: up one dir, main page]

Page MenuHomePhabricator

WE2.1: Icons that appear in the bottom right of the screen should be in a standardized menu
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

This will be needed in preparation for font-size and dark mode.

Many extensions and skins add an icon to the bottom right of the skin.
We need to standardize how this happens.

image.png (286×654 px, 32 KB)

Screenshot 2023-05-10 at 12.56.54.png (322×702 px, 35 KB)

Proposal:

  • We'll make the existing menu vector-settings extensible
  • Extensions will be updated to call mw.util.addPortletLink to populate it.

Code:
https://gerrit.wikimedia.org/g/mediawiki/extensions/GrowthExperiments/+/8e301066c3e06989b588d648564fd1ea57d9a227/modules/ext.growthExperiments.HelpPanel/HelpPanelCta.js#35

QA steps

Event Timeline

Those arrows in the first image are I believe absolute-positioned editor creations, not anything that extensions create. (I'm not a fan of the relevant template.)

(I think this is still probably worth solving, just that you can't do anything about those ultimately.)

@Izno thanks! Yeh to clarify those icons are out of scope and am not planning to touch them. Just the ? icon. However in future those would be better done in a gadget using mw.util.addPortletLink. I don't think templates should be doing this sort of thing as it makes too many assumptions about how the page is built.

Jdlrobson raised the priority of this task from Low to Medium.May 16 2023, 1:05 AM

@Jdlrobson The engineers discussed this last week in estimation, a few questions were raised about the approach of making this a menu.

While I see the advantage of standardizing customization to this area of the UI, conceptually, it seems like this section of the UI is distinct from the list of links that usually comprise a menu. What's the intended design for multiple menu items in .vector-settings, and does that even make sense (i.e. what happens if a gadget appends several links to .vector-settings)?
This approach also might require a large amount of work, currently we use hardcoded template data and the Button.mustache template to render the limited toggle button. The Button.mustache template isnt currently supported by the menu architecture and templates. Looking at the Growth extensions help panel, it seems to be implemented with OOUI and involves dialog and button widgets that are both absolutely or fixed positioned, which could be difficult to convert into menu items.

Currently the limited width toggle button is just hidden in this case, is that an insufficient solution?

Currently the limited width toggle button is just hidden in this case, is that an insufficient solution?

The issue of the tooltip being off the side of the screen should be fixed in either case.

In future this area is likely to become reserved for client side settings in which case it will be a popup. This work is important to start collating features in this area.

The only requirement for a menu to work with addPortletLink is to provide a UL tag and an element ID so this shouldn't be a large amount of work. Anything else is out of scope.

By making code use addPortletLink we are also empowering future versions of Vector to have more opinions on how this should be styled and the ability to add constraints such as number of items in the menu.

Change 923526 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Make bottom dock expansible via portlet links

https://gerrit.wikimedia.org/r/923526

@bwang does the patch above help explain the goal of this ticket? This ticket would also involve updating the existing usages in GrowthExperiments etc..

LGoto set the point value for this task to 3.Jun 1 2023, 5:56 PM
Jdlrobson renamed this task from Icons that appear in the bottom right of the screen should be in a standardized menu to WE2.1: Icons that appear in the bottom right of the screen should be in a standardized menu.Jun 23 2023, 5:53 PM
Jdlrobson updated the task description. (Show Details)

Change 923526 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Make bottom dock expansible via portlet links

https://gerrit.wikimedia.org/r/923526