[Unplanned] Regression: Additional margin relating to subtitle element in Minerva
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 9 2022, 10:30 PM

Description

Picked up by Pixel (33 failures):

This is most notable on non-existent user pages e.g. https://en.m.wikipedia.beta.wmflabs.org/w/index.php?title=User:User-0.7967016078790841-I%C3%B1t%C3%ABrn%C3%A2ti%C3%B4n%C3%A0liz%C3%A6ti%C3%B8n:

Screen Shot 2022-12-09 at 2.28.42 PM.png (321×1 px, 41 KB)

However pushes content ever so slightly on all mobile article pages:

To rectify this, we'll need to make several extensions use the new API first.

QA Results - Beta

AC	Status	Details
1	✅	T324876#8506046

Details

Subject	Repo	Branch	Lines +/-
Parse API should not include #mw-content-subtitle element	mediawiki/core	master	+7 -4
Use standard subtitle markup	mediawiki/skins/MinervaNeue	master	+4 -2
Use new stable API for subtitle modification	mediawiki/extensions/VisualEditor	master	+2 -2
Use new stable API for subtitle modification	mediawiki/extensions/DiscussionTools	master	+2 -2

Customize query in gerrit

Related Objects

Mentioned In: T316830: [M] Gadgets should have a reliable way to add content to the subtitle

Event Timeline

Jdlrobson created this task.Dec 9 2022, 10:30 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptDec 9 2022, 10:30 PM

Jdlrobson mentioned this in T316830: [M] Gadgets should have a reliable way to add content to the subtitle.Dec 9 2022, 10:31 PM

Change 866655 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/DiscussionTools@master] Use new stable API for subtitle modification

https://gerrit.wikimedia.org/r/866655

gerritbot added a project: Patch-For-Review.Dec 9 2022, 10:33 PM

ovasileva triaged this task as Low priority.Dec 9 2022, 10:34 PM

Change 866656 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@master] Use new stable API for subtitle modification

https://gerrit.wikimedia.org/r/866656

Change 866657 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Use standard subtitle markup

https://gerrit.wikimedia.org/r/866657

Change 867301 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Parse API should not include #mw-content-subtitle element

https://gerrit.wikimedia.org/r/867301

ovasileva moved this task from Incoming to Groomed on the Web-Team-Backlog board.Dec 13 2022, 5:31 PM

Change 867301 merged by jenkins-bot:

[mediawiki/core@master] Parse API should not include #mw-content-subtitle element

https://gerrit.wikimedia.org/r/867301

Change 866655 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Use new stable API for subtitle modification

https://gerrit.wikimedia.org/r/866655

Change 866656 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Use new stable API for subtitle modification

https://gerrit.wikimedia.org/r/866656

Change 866657 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Use standard subtitle markup

https://gerrit.wikimedia.org/r/866657

Maintenance_bot removed a project: Patch-For-Review.Dec 14 2022, 4:30 AM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 14 2022, 5:00 AM

matmarex subscribed.Dec 14 2022, 5:23 AM

This should be fixed now so moving into QA (beta cluster only). This can skip QA in production.

Jdlrobson renamed this task from Regression: Additional margin relating to subtitle element in Minerva to [Unplanned] Regression: Additional margin relating to subtitle element in Minerva.Dec 14 2022, 6:56 PM

Jdlrobson assigned this task to Edtadros.

Jdlrobson moved this task from Needs Analysis to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Mobile pages should not show any regressions on Pixel.
This may have been tested late. As of today there are no regressions showing on Pixel for mobile pages. Passing this and skipping testing in production per T324876#8468795

Edtadros updated the task description. (Show Details)Jan 7 2023, 12:32 AM

ovasileva closed this task as Resolved.Jan 9 2023, 5:24 PM

	F35848739: Screen Shot 2022-12-09 at 2.28.42 PM.png
	Dec 9 2022, 10:30 PM

[Unplanned] Regression: Additional margin relating to subtitle element in MinervaClosed, ResolvedPublicBUG REPORTActions