Maniphest T320804

[S] Infinite redirect on Special:Contribute (mediawiki.org)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	kostajh
	Oct 14 2022, 12:35 PM

Description

While logged-in with KHarlan_(WMF) I get an infinite redirect when attempt to visit Special:Contribute in Minerva (m subdomain) or on desktop (Vector 2022).

Seemingly this is the problematic code in SpecialContribute.php:

$target = $par ?? $request->getVal( 'target', '' );

$titleLocalUrl = static::getTitleFor( 'Contribute', $this->getUser()->getName() )->getLocalUrl();
if ( $target !== $this->getUser()->getName() ) {
   $this->getOutput()->redirect( $titleLocalUrl );
}

QA

Go to https://m.mediawiki.org/wiki/Special:Contribute

QA Results - Prod

AC	Status	Details
1	✅	T320804#8343928

Details

	Subject	Repo	Branch	Lines +/-
	SpecialContribute: Avoid unnecessary redirects and optimise showing logics	mediawiki/core	master	+21 -15

Customize query in gerrit

Related Objects

Mentioned In: T286466: Persistent contribution entry point on the mobile navigation menu

Event Timeline

kostajh created this task.Oct 14 2022, 12:35 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptOct 14 2022, 12:35 PM

kostajh updated the task description. (Show Details)Oct 14 2022, 12:36 PM

kostajh mentioned this in T286466: Persistent contribution entry point on the mobile navigation menu.

• Mabualruz subscribed.Oct 14 2022, 3:30 PM

Jdlrobson triaged this task as High priority.Oct 14 2022, 3:31 PM

Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q2); removed Web-Team-Backlog.

The underscore/space in user name didn't get normalized, but why it needs to be redirected to the subpage with user name?

jhsoby subscribed.Oct 15 2022, 1:06 AM

Change 842399 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] SpecialContribute: Avoid unnecessary redirects and optimise showing checks

https://gerrit.wikimedia.org/r/842399

gerritbot added a project: Patch-For-Review.Oct 15 2022, 5:02 AM

santhosh subscribed.Oct 17 2022, 11:16 AM

KartikMistry subscribed.Oct 17 2022, 11:18 AM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.Oct 17 2022, 5:11 PM

Jdlrobson updated the task description. (Show Details)Oct 17 2022, 10:29 PM

Change 842399 merged by jenkins-bot:

[mediawiki/core@master] SpecialContribute: Avoid unnecessary redirects and optimise showing logics

https://gerrit.wikimedia.org/r/842399

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.7; 2022-10-24).Oct 18 2022, 4:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 18 2022, 4:30 AM

LGoto set the point value for this task to 1.Oct 18 2022, 5:00 PM

LGoto renamed this task from Infinite redirect on Special:Contribute (mediawiki.org) to [S] Infinite redirect on Special:Contribute (mediawiki.org).Oct 18 2022, 5:06 PM

LGoto moved this task from Upcoming to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

Jdlrobson assigned this task to Edtadros.Oct 18 2022, 5:06 PM

Jdlrobson moved this task from QA to Needs More Work on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog (Kanbanana-2022-23-Q2) board.

Note: This patch didn't catch the train of 1.40/wmf.6, so it is not ready to QA in prod.

Aklapper added a project: MediaWiki-Special-pages.Oct 25 2022, 10:39 AM

Test Result - Prod

Status: ✅ PASS
Environment: mediawiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Go to https://m.mediawiki.org/wiki/Special:Contribute. Confirm there are no infinite redirects. Repeat for Vector 2022.
Note I only tested this in Production. No redirects were present in the network tab of devtools.

Screen Recording 2022-10-25 at 3.21.53 PM.mov.gif (548×1 px, 324 KB)

Edtadros updated the task description. (Show Details)Oct 25 2022, 10:30 PM

Looks good, resolving!

	F35627671: Screen Recording 2022-10-25 at 3.21.53 PM.mov.gif
	Oct 25 2022, 10:29 PM

[S] Infinite redirect on Special:Contribute (mediawiki.org)Closed, ResolvedPublic1 Estimated Story PointsActions