[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T297019

Editors should be able to blank the main page title without MediaWiki:Vector.css changes for Vector
Closed, ResolvedPublicBUG REPORT
Actions

Description

Many projects hide the heading on the main page on Vector.
They often do this using an !important rule inside MediaWiki:Vector.css
It's proposed we provide an HTML based approach to doing that, by allowing editors to blank the page.

Currently blanking the page, disables a message, and when disabled

Screen Shot 2021-12-03 at 9.34.45 AM.png (890×1 px, 262 KB)

Given the changes in T255682 we could make it adapt this to make it possible to do this without the CSS changes.

The main page title is now controlled by a message mainpage-title.

https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page?uselang=qqx&safemode=1

Proposal

  • Editors can blank the associated message to remove the heading on both Vector and Minerva (needs changes in Vector and Minerva for this to work).
  • The title attribute is not impacted by the change

Details

SubjectRepoBranchLines +/-
Use html-title-heading template data provided by coremediawiki/skins/CologneBluemaster+3 -3
Hiding main page heading should not hide title on diff/history viewsmediawiki/coremaster+5 -1
Allow editors to blank the heading, standardize heading classmediawiki/coremaster+33 -10
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Dec 3 2021, 5:55 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptDec 3 2021, 5:55 PM
gerritbot added a comment.Dec 3 2021, 5:56 PM

Change 743465 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Allow editors to blank the heading, standardize heading class

https://gerrit.wikimedia.org/r/743465

gerritbot added a project: Patch-For-Review.Dec 3 2021, 5:56 PM
Jdlrobson mentioned this in T255682: Formalize Main page heading behaviour.Dec 3 2021, 5:57 PM
Jdlrobson moved this task from Backlog to Small HTML modifications to support our users better on the MediaWiki-Core-Skin-Architecture board.Dec 4 2021, 1:29 AM
Jdlrobson triaged this task as High priority.Dec 7 2021, 2:45 AM
Izno subscribed.Dec 7 2021, 2:46 PM
gerritbot added a comment.Dec 8 2021, 9:26 AM

Change 743465 merged by jenkins-bot:

[mediawiki/core@master] Allow editors to blank the heading, standardize heading class

https://gerrit.wikimedia.org/r/743465

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 8 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 8 2021, 10:10 AM
Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2021-22).EditedDec 22 2021, 1:13 AM

This will be usable in Vector and Minerva soon due to the work in T297728 and T265892

I'll verify that change and sign off in wmf14 in the new year.

Jdlrobson claimed this task.Dec 22 2021, 1:13 AM
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Lens0021 subscribed.Dec 22 2021, 11:06 AM
Jdlrobson removed Jdlrobson as the assignee of this task.Dec 22 2021, 9:30 PM
Jdlrobson moved this task from Ready for Signoff to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Dec 22 2021, 9:31 PM

Change 749580 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Hiding main page heading should not hide title on diff/history views

https://gerrit.wikimedia.org/r/749580

gerritbot added a project: Patch-For-Review.Dec 22 2021, 9:31 PM
Jdlrobson mentioned this in T38294: It should be possible to hide the heading on the main page without hiding the heading on its associated diff page.Dec 22 2021, 9:36 PM
matmarex subscribed.Dec 23 2021, 8:59 PM
gerritbot added a comment.Dec 24 2021, 12:43 AM

Change 749580 merged by jenkins-bot:

[mediawiki/core@master] Hiding main page heading should not hide title on diff/history views

https://gerrit.wikimedia.org/r/749580

Maintenance_bot removed a project: Patch-For-Review.Dec 24 2021, 1:10 AM
Jdlrobson assigned this task to Edtadros.Dec 24 2021, 2:28 AM
Jdlrobson claimed this task.
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from QA to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: Edtadros.
Jdlrobson closed this task as Resolved.Jan 6 2022, 5:51 PM

I tried this change out on Italian Wikipedia and it works as expected.

I've communicated this out to communities T298715

Jdlrobson reopened this task as Open.Jan 7 2022, 12:04 AM
Jdlrobson removed Jdlrobson as the assignee of this task.
Jdlrobson moved this task from Ready for Signoff to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

A bug in the implementation has been flagged: T298715#7603292

Jdlrobson claimed this task.Jan 7 2022, 12:19 AM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson closed this task as Resolved.Jan 11 2022, 4:29 PM

All feedback has been addressed. Thursday will see improvements to the feature to use content language, and work on more skins.

Od1n subscribed.Apr 1 2022, 4:09 AM
  1. Back in 2009, class .firstHeading had been replaced with an ID #firstHeading, see T17427 and https://phabricator.wikimedia.org/rMWc68f345d54c3
  2. Very soon after, the class .firstHeading has been restored, alongside the ID, for backward compatibility, see https://phabricator.wikimedia.org/rMWba0f7c4c1378
  3. In 2014, the ID has been considered obsolete, see https://phabricator.wikimedia.org/rMW7d244175a3bd359bd and also this documentation update.
  4. The present ticket introduced a new class .mw-first-heading for name standardization.

Therefore, am I right assuming that both #firstHeading and .firstHeading should now be considered obsolete?

Od1n added a comment.EditedApr 1 2022, 4:15 AM

Currently all skins have #firstHeading, .firstHeading and .mw-first-heading, the only exception being CologneBlue which only has #firstHeading.

Jdlrobson added a comment.Apr 1 2022, 2:35 PM

@Od1n yes mw-first-heading should now be considered the standard class. Others are obsolete.
Patch for CologneBlue is welcome. I can review.

Od1n added a comment.Apr 1 2022, 3:37 PM

I just noticed the .mw-first-heading is missing here:
https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/475508647466ea1c67d3e0d378ca3b4a76668e84/stories/skin.stories.data.js#91

(code search)

gerritbot added a comment.Apr 1 2022, 4:28 PM

Change 776234 had a related patch set uploaded (by Gerrit Patch Uploader; author: Fernand Dell):

[mediawiki/skins/CologneBlue@master] Use html-title-heading template data provided by core

https://gerrit.wikimedia.org/r/776234

gerritbot added a project: Patch-For-Review.Apr 1 2022, 4:28 PM
gerritbot added a comment.Apr 1 2022, 5:14 PM

Change 776234 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@master] Use html-title-heading template data provided by core

https://gerrit.wikimedia.org/r/776234

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2022, 6:11 PM
Od1n added a comment.Oct 2 2022, 4:28 AM

I have updated the list of IDs and classes in the documentation: edits 5499359, 5499361, and 5499362.

To summarize, I have added .mw-first-heading and made it the recommended selector, and deprecated .firstHeading.
Though, older MediaWiki versions don't have .mw-first-heading yet, so I pointed to .firstHeading as possibly the adequate selector, still.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits