[go: up one dir, main page]

Page MenuHomePhabricator

1.38.0-wmf.9 introduces visible page title on main page for anonymous readers, interfering with design
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
Main page has a title, which can be bad in cases where main pages already have their own page titles, especially since they are usually hidden by default on desktop. You cannot easily hide the page title on mobile because mobile uses awful JS loading for its Mobile.css, so if editors wanted to hide it like would be the most logical, they would have to either resolve to bad hacks with CSS or have everyone see page jumps.

What should have happened instead?:
Mobile version should not have a page title for anonymous readers.

Event Timeline

cjming triaged this task as Medium priority.Nov 19 2021, 10:01 PM
cjming added a project: Web-Team-Backlog.

Change 740298 had a related patch set uploaded (by Tacsipacsi; author: Tacsipacsi):

[mediawiki/skins/MinervaNeue@master] Don\u2019t add any <h1> to main pages for anons

https://gerrit.wikimedia.org/r/740298

By the way, I don’t think it’s really a train blocker—it’s annoying, especially on main pages, but doesn’t break any workflows or cause logspam. However, hopefully it doesn’t matter whether it’s a train blocker as the patch is ready and can be reviewed and merged during the weekend (or early next week, although I won’t have much time to respond to the review during the week).

Urbanecm added a project: User-Urbanecm.
Urbanecm subscribed.

I don't think this is serious enough to be treated as a blocker. I approved the patch, which will be deployed via next train. It can be scheduled for a backport window, as it looks to be an annoying regression :).

Change 740298 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Don\u2019t add any <h1> to main pages for anons

https://gerrit.wikimedia.org/r/740298

@Urbanecm Thanks for both the +2 and the removal as a train blocker. Unfortunately I won’t be available to do a backport this week (unless my in-person events get cancelled due to COVID…), but if someone wants to backport, go for it!

Just to clarify, will the <title> still have the correct title (MediaWiki:Pagetitle-view-mainpage) with this patch? (It does need backporting if the next train will be 1.38.0-wmf.9 again, yes. I am not well-versed in this tbh.)

(As to train blocking: yes, probably not, I mostly was treating it as ‘this will be an issue’ thing given that I saw this bug one day and then the train was rolled back the other day.)

Yes, the <title> will be the same as what’s currently in wmf.9, i.e. on testwiki; only the <h1> changed (disappeared). You would be able to see the result of the merged patch on beta cluster if it wasn’t down for more than a day by now (T296125)…

Jdlrobson subscribed.

The change here does not look like the right one, but work in T293470 and T255682 will fix this.