[go: up one dir, main page]
Page MenuHomePhabricator
Create Task
Maniphest T293941

[Regression] Browser tab title broken for mobile main page ("- Wikipedia")
Closed, DuplicatePublicBUG REPORT
Actions

Description

https://en.m.wikipedia.org/wiki/Main_Page

What happens?:

Document title is - Wikipedia.

What should have happened instead?:

The title is expected to be Wikipedia, the free encyclopedia, as controlled by the pagetitle-view-mainpage messsage, and as seen on the equivalent page at the canonical/desktop URL https://en.wikipedia.org/wiki/Main_Page.

If I remember correctly, MobileFrontend does not (intentionally) override this, so I'm guessing it's not that an override fell apart, but rather that a bug caused it to start affecting the logic at all.

I don't know when it regressed, could be a couple days or a couple months.

Related Objects

Event Timeline

Krinkle created this task.Oct 20 2021, 9:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 20 2021, 9:40 PM
Krinkle added a comment.Oct 20 2021, 9:45 PM

With the help of the Wayback Machine I narrowed it down to having regressed between 15 Oct 2020 and 16 Oct 2020, and indeed in the months and years upto that point, it read Wikipedia, the free encyclopedia as presumably set by OutputPage in core.

http://web.archive.org/web/20200101000000*/https://en.m.wikipedia.org/wiki/Main_Page
http://web.archive.org/web/20201015071412/https://en.m.wikipedia.org/wiki/Main_Page
http://web.archive.org/web/20201016005448/https://en.m.wikipedia.org/wiki/Main_Page

Krinkle added a project: Web-Team-Backlog.Oct 20 2021, 9:45 PM
Ammarpad subscribed.EditedOct 20 2021, 10:23 PM

The override is in MinervaNeue (now).

pagetitle-view-mainpage is supplanted by MediaWiki:Mobile-frontend-logged-in-homepage-notification, which itself is argument for MediaWiki:Pagetitle. For unregistered users, the first message is indeed empty string (since there's no name to welcome) which is what produces the dangling - Wikipedia. For registered users, it should look correct.

Jdlrobson closed this task as a duplicate of T255682: Formalize Main page heading behaviour.Oct 27 2021, 8:10 PM
stjn added subscribers: Jdlrobson, stjn.EditedOct 28 2021, 10:22 PM

@Jdlrobson: While this is certainly a duplicate, this merge seems to be in error. T255682: Formalize Main page heading behaviour is a task about <h1> tag, this task is about <title> tag in <head>.

My own T277410 filed over the same issue seems to show that the proper task for this duplicate is actually T265892: MediaWiki:Pagetitle-view-mainpage does not behave the same in MinervaNeue skin as it does in other skin.

Jdlrobson added a comment.Oct 29 2021, 11:06 PM

Yeh there's a fair bit of overlap between those two tasks. Hoping to carve out some time to fix this soon. Basically one patch should fix both issues.

OutputPage::setPageTitle sets mPageTitle which is returned by OutputPage::getPageTitle
It however also calls setHTMLTitle which updates the title in the HEAD.D

SkinMinerva needs to be updated to use OutputPage::setDisplayTitle and OutputPage::getDisplayTitle to fix both bugs.

gerritbot added a comment.Nov 5 2021, 6:24 PM

Change 737112 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Minerva uses core page title handling

https://gerrit.wikimedia.org/r/737112

gerritbot added a project: Patch-For-Review.Nov 5 2021, 6:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits