Maniphest T190718

Tag filters' titles and descriptions should be bidi isolated
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mooeypoo
	Mar 26 2018, 8:04 PM

Description

Tag filters are externally added and we don't control their content. They can be added as English strings or any other language, without concern to the interface or wiki language direction. We have to bidi isolate these so they don't break.

Example of broken English tags in Hebrew Wiki:

rcfilters-rtl-isolate.png (566×684 px, 74 KB)

Details

	Subject	Repo	Branch	Lines +/-
	RCFilters: Followup Iebc3176c5d: Bidi isolate filter tags	mediawiki/core	master	+9 -3
	RCFilters: Bidi isolate tag names and descriptions	mediawiki/core	master	+2 -2

Customize query in gerrit

Event Timeline

Mooeypoo created this task.Mar 26 2018, 8:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2018, 8:04 PM

Change 421985 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Bidi isolate tag names and descriptions

https://gerrit.wikimedia.org/r/421985

gerritbot added a project: Patch-For-Review.Mar 26 2018, 8:05 PM

Mooeypoo moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Mar 26 2018, 8:05 PM

Aklapper added a project: I18n.Mar 26 2018, 8:25 PM

• Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Mar 28 2018, 12:23 PM

Change 421985 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Bidi isolate tag names and descriptions

https://gerrit.wikimedia.org/r/421985

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)).Mar 28 2018, 1:00 PM

@Mooeypoo Is there bidi for filter capsule? The tag is displayed correctly in the list of tags but not when when the tag is selected:

Screen Shot 2018-03-28 at 3.39.43 PM.png (463×702 px, 54 KB)

Trizek-WMF added projects: User-notice, User-notice-collaboration.Mar 29 2018, 1:14 PM

Change 423028 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] Followup Iebc3176c5d: Bidi isolate filter tags

https://gerrit.wikimedia.org/r/423028

@Etonkovidova whoops! Good catch! Added that in this commit.

Mooeypoo moved this task from QA Review to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Mar 29 2018, 7:47 PM

Change 423028 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Followup Iebc3176c5d: Bidi isolate filter tags

https://gerrit.wikimedia.org/r/423028

The change to bd isolate the capsules was just merged.

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)); removed MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)).Apr 4 2018, 4:00 PM

Johan moved this task from To Triage to In current Tech/News draft on the User-notice board.Apr 5 2018, 7:01 PM

Fixed in betalabs:

Screen Shot 2018-04-05 at 12.28.33 PM.png (685×725 px, 77 KB)

Trizek-WMF moved this task from Untriaged to RTL on the I18n board.Apr 6 2018, 9:40 AM

Trizek-WMF subscribed.

This comment was removed by Trizek-WMF.

Trizek-WMF moved this task from To Triage to Announce in next Collaboration Newsletter on the User-notice-collaboration board.Apr 6 2018, 9:40 AM

Trizek-WMF moved this task from Announce in next Collaboration Newsletter to In current Collaboration Newsletter draft on the User-notice-collaboration board.Apr 11 2018, 2:13 PM

RandomDSdevel awarded a token.Apr 11 2018, 10:10 PM

Johan moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Apr 12 2018, 4:40 PM

Liuxinyu970226 awarded a token.Aug 14 2018, 1:14 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 14 2018, 1:14 AM

Ladsgroup edited projects, added User-notice-archive; removed User-notice.Aug 13 2022, 1:53 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 13 2022, 2:30 PM

	F16722152: Screen Shot 2018-04-05 at 12.28.33 PM.png
	Apr 5 2018, 7:30 PM

	F16384859: Screen Shot 2018-03-28 at 3.39.43 PM.png
	Mar 28 2018, 10:42 PM

Tag filters' titles and descriptions should be bidi isolatedClosed, ResolvedPublicActions

Description

Details

Event Timeline

Tag filters' titles and descriptions should be bidi isolated
Closed, ResolvedPublic
Actions