[go: up one dir, main page]

Page MenuHomePhabricator

confctl: log to SAL even if the selection doesn't match any host
Open, MediumPublic

Description

Look like confctl is logging to IRC and then SAL even when it doesn't match any host if run without the --quiet flag.
If no host is matched probably there is no point in logging it to IRC/SAL.

Running this with a non-existing hostname:

$ sudo confctl select 'name=mw2098.wmnet' set/pooled=inactive
WARNING:conftool.announce:conftool action : set/pooled=inactive; selector: name=mw2098.wmnet

Ended up logging on IRC and SAL this:

logmsgbot| !log volans@puppetmaster1001 conftool action : set/pooled=inactive; selector: name=mw2098.wmnet

Event Timeline

Also there's nothing logged on stdout on non-existent host and conftool exits 0. Ditto for a non-existant service

For future reference, this is still happening, hence keeping the task open.

Volans added a subscriber: Scott_French.

Fixing tags and subscribers.