From 73f84154795f8cf41e81fdbe8016a3e24a336bc3 Mon Sep 17 00:00:00 2001 From: Graeme Britz Date: Thu, 21 Sep 2017 08:28:42 -0700 Subject: [PATCH 1/2] 226 fix populate connections bug (#227) * added namespace to call on line 60 * separated code into 2 lines to pass E501 standards (<120 chars) --- tableauserverclient/server/endpoint/datasources_endpoint.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tableauserverclient/server/endpoint/datasources_endpoint.py b/tableauserverclient/server/endpoint/datasources_endpoint.py index 1704fd5ac..b50d5d543 100644 --- a/tableauserverclient/server/endpoint/datasources_endpoint.py +++ b/tableauserverclient/server/endpoint/datasources_endpoint.py @@ -57,7 +57,8 @@ def populate_connections(self, datasource_item): raise MissingRequiredFieldError(error) url = '{0}/{1}/connections'.format(self.baseurl, datasource_item.id) server_response = self.get_request(url) - datasource_item._set_connections(ConnectionItem.from_response(server_response.content)) + datasource_item._set_connections( + ConnectionItem.from_response(server_response.content, self.parent_srv.namespace)) logger.info('Populated connections for datasource (ID: {0})'.format(datasource_item.id)) # Delete 1 datasource by id From c138764b726ba45f042e88f3981792728629fa71 Mon Sep 17 00:00:00 2001 From: Russell Hay Date: Thu, 21 Sep 2017 08:32:51 -0700 Subject: [PATCH 2/2] Update Change Log --- CHANGELOG.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 12a95d31b..c4fece541 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,8 @@ -## 0.5 (11 Sept 2017) +## 0.5.1 (21 Sept 2017 + +* Fix a critical issue caused by #224 that was the result of lack of test coverage (#226) + +## 0.5 (20 Sept 2017) * Added revision settings to update site (#187) * Added support for certified data sources (#189)