From 60d7ed73c39509a9365f3214329bbe7c52b02268 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Thu, 2 Nov 2023 09:39:23 +0100 Subject: [PATCH] clean up legacy test --- .../Tests/Fixtures/ini/types_legacy.ini | 32 ------------ .../Tests/Loader/IniFileLoaderTest.php | 50 ------------------- 2 files changed, 82 deletions(-) delete mode 100644 src/Symfony/Component/DependencyInjection/Tests/Fixtures/ini/types_legacy.ini diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/ini/types_legacy.ini b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/ini/types_legacy.ini deleted file mode 100644 index a2868c8eecbff..0000000000000 --- a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/ini/types_legacy.ini +++ /dev/null @@ -1,32 +0,0 @@ -[parameters] - true = true - true_comment = true ; comment - false = false - null = null - on = on - off = off - yes = yes - no = no - none = none - constant = PHP_VERSION - 12 = 12 - 12_string = '12' - 12_quoted_number = "12" - 12_comment = 12 ; comment - 12_string_comment = '12' ; comment - 12_quoted_number_comment = "12" ; comment - -12 = -12 - 0 = 0 - 1 = 1 - 0b0110 = 0b0110 - 11112222333344445555 = 1111,2222,3333,4444,5555 - 0777 = 0777 - 255 = 0xFF - 100.0 = 1e2 - -120.0 = -1.2E2 - -10100.1 = -10100.1 - -10,100.1 = -10,100.1 - list[] = 1 - list[] = 2 - map[one] = 1 - map[two] = 2 diff --git a/src/Symfony/Component/DependencyInjection/Tests/Loader/IniFileLoaderTest.php b/src/Symfony/Component/DependencyInjection/Tests/Loader/IniFileLoaderTest.php index e2b3697283c2b..dfc1ccf21306a 100644 --- a/src/Symfony/Component/DependencyInjection/Tests/Loader/IniFileLoaderTest.php +++ b/src/Symfony/Component/DependencyInjection/Tests/Loader/IniFileLoaderTest.php @@ -93,56 +93,6 @@ public static function getTypeConversions() ]; } - /** - * @group legacy - * - * @dataProvider getLegacyTypeConversions - */ - public function testLegacyTypeConversionsWithNativePhp($key, $value, $supported) - { - if (!$supported) { - $this->markTestSkipped(sprintf('Converting the value "%s" to "%s" is not supported by the IniFileLoader.', $key, $value)); - } - - $expected = parse_ini_file(__DIR__.'/../Fixtures/ini/types_legacy.ini', true, \INI_SCANNER_TYPED); - $this->assertSame($value, $expected['parameters'][$key], '->load() converts values to PHP types'); - } - - public static function getLegacyTypeConversions() - { - return [ - ['true_comment', true, true], - ['true', true, true], - ['false', false, true], - ['on', true, true], - ['off', false, true], - ['yes', true, true], - ['no', false, true], - ['none', false, true], - ['null', null, true], - ['constant', \PHP_VERSION, true], - ['12', 12, true], - ['12_string', '12', true], - ['12_quoted_number', 12, false], // INI_SCANNER_RAW removes the double quotes - ['12_comment', 12, true], - ['12_string_comment', '12', true], - ['12_quoted_number_comment', 12, false], // INI_SCANNER_RAW removes the double quotes - ['-12', -12, true], - ['1', 1, true], - ['0', 0, true], - ['0b0110', bindec('0b0110'), false], // not supported by INI_SCANNER_TYPED - ['11112222333344445555', '1111,2222,3333,4444,5555', true], - ['0777', 0777, false], // not supported by INI_SCANNER_TYPED - ['255', 0xFF, false], // not supported by INI_SCANNER_TYPED - ['100.0', 1e2, false], // not supported by INI_SCANNER_TYPED - ['-120.0', -1.2E2, false], // not supported by INI_SCANNER_TYPED - ['-10100.1', -10100.1, false], // not supported by INI_SCANNER_TYPED - ['-10,100.1', '-10,100.1', true], - ['list', [1, 2], true], - ['map', ['one' => 1, 'two' => 2], true], - ]; - } - public function testExceptionIsRaisedWhenIniFileDoesNotExist() { $this->expectException(\InvalidArgumentException::class);