From 99f0c67cbe75bda8d35f25763598ee3d4d2bf989 Mon Sep 17 00:00:00 2001 From: aa Date: Sat, 12 Mar 2016 20:13:41 +0100 Subject: [PATCH 1/2] Exposed getter for baseHref in DomCrawler --- src/Symfony/Component/DomCrawler/Crawler.php | 10 ++++++++++ src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php | 6 ++++++ 2 files changed, 16 insertions(+) diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php index 5600995786c36..c6a2752864d8e 100644 --- a/src/Symfony/Component/DomCrawler/Crawler.php +++ b/src/Symfony/Component/DomCrawler/Crawler.php @@ -72,6 +72,16 @@ public function __construct($node = null, $currentUri = null, $baseHref = null) $this->add($node); } + /** + * Returns base href. + * + * @return string + */ + public function getBaseHref() + { + return $this->baseHref; + } + /** * Removes all the nodes. */ diff --git a/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php b/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php index 13b92fa610c78..fb6508a706fb5 100755 --- a/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php +++ b/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php @@ -27,6 +27,12 @@ public function testConstructor() $this->assertCount(1, $crawler, '__construct() takes a node as a first argument'); } + public function testGetBaseHref() + { + $crawler = new Crawler(null, null, 'http://symfony.com'); + $this->assertEquals('http://symfony.com', $crawler->getBaseHref()); + } + public function testAdd() { $crawler = new Crawler(); From 10fb2abf096e31d1e2eeda58c1ebaa5a5ee77917 Mon Sep 17 00:00:00 2001 From: aa Date: Sun, 13 Mar 2016 10:01:32 +0100 Subject: [PATCH 2/2] Extracted baseHref as the variable --- src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php b/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php index fb6508a706fb5..c51d511c2f7d2 100755 --- a/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php +++ b/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php @@ -29,8 +29,9 @@ public function testConstructor() public function testGetBaseHref() { - $crawler = new Crawler(null, null, 'http://symfony.com'); - $this->assertEquals('http://symfony.com', $crawler->getBaseHref()); + $baseHref = 'http://symfony.com'; + $crawler = new Crawler(null, null, $baseHref); + $this->assertEquals($baseHref, $crawler->getBaseHref()); } public function testAdd()