From 07089fed58de478c436c72c11347825036c6da5f Mon Sep 17 00:00:00 2001 From: "Thomas J. Fan" Date: Sat, 25 Feb 2023 09:01:15 -0500 Subject: [PATCH 1/3] CI Stablize build with random_state --- sklearn/neural_network/tests/test_mlp.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/sklearn/neural_network/tests/test_mlp.py b/sklearn/neural_network/tests/test_mlp.py index 6db1f965dad7e..ac5a6ec47774b 100644 --- a/sklearn/neural_network/tests/test_mlp.py +++ b/sklearn/neural_network/tests/test_mlp.py @@ -919,7 +919,11 @@ def test_preserve_feature_names(Estimator): def test_mlp_warm_start_with_early_stopping(MLPEstimator): """Check that early stopping works with warm start.""" mlp = MLPEstimator( - max_iter=10, random_state=0, warm_start=True, early_stopping=True + max_iter=10, + random_state=0, + warm_start=True, + early_stopping=True, + random_state=0, ) mlp.fit(X_iris, y_iris) n_validation_scores = len(mlp.validation_scores_) @@ -937,7 +941,11 @@ def test_mlp_warm_start_no_convergence(MLPEstimator, solver): https://github.com/scikit-learn/scikit-learn/issues/24764 """ model = MLPEstimator( - solver=solver, warm_start=True, early_stopping=False, max_iter=10 + solver=solver, + warm_start=True, + early_stopping=False, + max_iter=10, + random_state=0, ) with pytest.warns(ConvergenceWarning): From 30666aa4dd7d5eae249bbd10ed1ad755b2ca45cd Mon Sep 17 00:00:00 2001 From: "Thomas J. Fan" Date: Sat, 25 Feb 2023 09:01:43 -0500 Subject: [PATCH 2/3] CI Stablize build with random_state --- sklearn/neural_network/tests/test_mlp.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/sklearn/neural_network/tests/test_mlp.py b/sklearn/neural_network/tests/test_mlp.py index ac5a6ec47774b..cd9c52c57e8ff 100644 --- a/sklearn/neural_network/tests/test_mlp.py +++ b/sklearn/neural_network/tests/test_mlp.py @@ -919,11 +919,7 @@ def test_preserve_feature_names(Estimator): def test_mlp_warm_start_with_early_stopping(MLPEstimator): """Check that early stopping works with warm start.""" mlp = MLPEstimator( - max_iter=10, - random_state=0, - warm_start=True, - early_stopping=True, - random_state=0, + max_iter=10, random_state=0, warm_start=True, early_stopping=True ) mlp.fit(X_iris, y_iris) n_validation_scores = len(mlp.validation_scores_) From 9f706c92e93618fd66cf160543706aab7aead7ab Mon Sep 17 00:00:00 2001 From: "Thomas J. Fan" Date: Mon, 27 Feb 2023 11:23:23 -0500 Subject: [PATCH 3/3] Update sklearn/neural_network/tests/test_mlp.py MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com> --- sklearn/neural_network/tests/test_mlp.py | 1 + 1 file changed, 1 insertion(+) diff --git a/sklearn/neural_network/tests/test_mlp.py b/sklearn/neural_network/tests/test_mlp.py index cd9c52c57e8ff..29dae84a149de 100644 --- a/sklearn/neural_network/tests/test_mlp.py +++ b/sklearn/neural_network/tests/test_mlp.py @@ -941,6 +941,7 @@ def test_mlp_warm_start_no_convergence(MLPEstimator, solver): warm_start=True, early_stopping=False, max_iter=10, + n_iter_no_change=np.inf, random_state=0, )