From c4308fd05c9c8371baa272e859cd5090b3cd1cbb Mon Sep 17 00:00:00 2001 From: Furkan Onder Date: Sun, 15 Sep 2024 22:08:38 +0300 Subject: [PATCH 1/2] Skip test_strcoll_with_diacritic and test_strxfrm_with_diacritic on NetBSD due to lack of UTF-8 LC_COLLATE support --- Lib/test/test_locale.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Lib/test/test_locale.py b/Lib/test/test_locale.py index da4bd79746a476..c73783fad05886 100644 --- a/Lib/test/test_locale.py +++ b/Lib/test/test_locale.py @@ -355,6 +355,8 @@ def setUp(self): is_emscripten or is_wasi, "musl libc issue on Emscripten/WASI, bpo-46390" ) + @unittest.skipIf(sys.platform.startswith("netbsd"), + "GH-124108: NetBSD doesn't support UTF-8 for LC_COLLATE") def test_strcoll_with_diacritic(self): self.assertLess(locale.strcoll('à', 'b'), 0) @@ -364,6 +366,8 @@ def test_strcoll_with_diacritic(self): is_emscripten or is_wasi, "musl libc issue on Emscripten/WASI, bpo-46390" ) + @unittest.skipIf(sys.platform.startswith("netbsd"), + "GH-124108: NetBSD doesn't support UTF-8 for LC_COLLATE") def test_strxfrm_with_diacritic(self): self.assertLess(locale.strxfrm('à'), locale.strxfrm('b')) From 564c262f3eeea818eec0198cc8c20dfb1f823308 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Mon, 16 Sep 2024 23:23:52 +0200 Subject: [PATCH 2/2] Apply suggestions from code review --- Lib/test/test_locale.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_locale.py b/Lib/test/test_locale.py index c73783fad05886..00e93d8e78443d 100644 --- a/Lib/test/test_locale.py +++ b/Lib/test/test_locale.py @@ -356,7 +356,7 @@ def setUp(self): "musl libc issue on Emscripten/WASI, bpo-46390" ) @unittest.skipIf(sys.platform.startswith("netbsd"), - "GH-124108: NetBSD doesn't support UTF-8 for LC_COLLATE") + "gh-124108: NetBSD doesn't support UTF-8 for LC_COLLATE") def test_strcoll_with_diacritic(self): self.assertLess(locale.strcoll('à', 'b'), 0) @@ -367,7 +367,7 @@ def test_strcoll_with_diacritic(self): "musl libc issue on Emscripten/WASI, bpo-46390" ) @unittest.skipIf(sys.platform.startswith("netbsd"), - "GH-124108: NetBSD doesn't support UTF-8 for LC_COLLATE") + "gh-124108: NetBSD doesn't support UTF-8 for LC_COLLATE") def test_strxfrm_with_diacritic(self): self.assertLess(locale.strxfrm('à'), locale.strxfrm('b'))