From 0d4a5fb070de28fd58e67ab0d87b4d1cbe5ec8ea Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Mon, 26 Nov 2018 17:28:22 +0100 Subject: [PATCH] bpo-33723: Remove busy loop from test_time The "busy loops" of test_process_time() and test_thread_time() are not reliable and fail randomly on different CIs. Remove the tests to make the CIs more reliable. --- Lib/test/test_time.py | 37 ------------------------------------- 1 file changed, 37 deletions(-) diff --git a/Lib/test/test_time.py b/Lib/test/test_time.py index 16b48a92f327dc..2a1a6748cd41b2 100644 --- a/Lib/test/test_time.py +++ b/Lib/test/test_time.py @@ -495,24 +495,6 @@ def test_process_time(self): # on Windows self.assertLess(stop - start, 0.020) - # bpo-33723: A busy loop of 100 ms should increase process_time() - # by at least 15 ms - min_time = 0.015 - busy_time = 0.100 - - # process_time() should include CPU time spent in any thread - start = time.process_time() - busy_wait(busy_time) - stop = time.process_time() - self.assertGreaterEqual(stop - start, min_time) - - t = threading.Thread(target=busy_wait, args=(busy_time,)) - start = time.process_time() - t.start() - t.join() - stop = time.process_time() - self.assertGreaterEqual(stop - start, min_time) - info = time.get_clock_info('process_time') self.assertTrue(info.monotonic) self.assertFalse(info.adjustable) @@ -533,25 +515,6 @@ def test_thread_time(self): # on Windows self.assertLess(stop - start, 0.020) - # bpo-33723: A busy loop of 100 ms should increase thread_time() - # by at least 15 ms - min_time = 0.015 - busy_time = 0.100 - - # thread_time() should include CPU time spent in current thread... - start = time.thread_time() - busy_wait(busy_time) - stop = time.thread_time() - self.assertGreaterEqual(stop - start, min_time) - - # ...but not in other threads - t = threading.Thread(target=busy_wait, args=(busy_time,)) - start = time.thread_time() - t.start() - t.join() - stop = time.thread_time() - self.assertLess(stop - start, min_time) - info = time.get_clock_info('thread_time') self.assertTrue(info.monotonic) self.assertFalse(info.adjustable)