From 8e7e5c6cadf07fd7836a067a81afac0894f54a03 Mon Sep 17 00:00:00 2001 From: kurt-rhee Date: Wed, 6 Jul 2022 10:44:47 -0700 Subject: [PATCH 1/8] docstring updated to indicate limits of axis_tilt --- pvlib/tracking.py | 1 + 1 file changed, 1 insertion(+) diff --git a/pvlib/tracking.py b/pvlib/tracking.py index d9cd2b7853..a3442dd044 100644 --- a/pvlib/tracking.py +++ b/pvlib/tracking.py @@ -21,6 +21,7 @@ class SingleAxisTracker(PVSystem): axis_tilt : float, default 0 The tilt of the axis of rotation (i.e, the y-axis defined by axis_azimuth) with respect to horizontal, in decimal degrees. + axis_azimuth must be >= 0 and <= 90. axis_azimuth : float, default 0 A value denoting the compass direction along which the axis of From f650ecc0ac4c27599f69058164f0ab2fa79a9090 Mon Sep 17 00:00:00 2001 From: kurt-rhee Date: Thu, 7 Jul 2022 06:33:55 -0700 Subject: [PATCH 2/8] updated additional docstrings where the axis_tilt variable is found --- pvlib/tracking.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/pvlib/tracking.py b/pvlib/tracking.py index a3442dd044..559553f5f1 100644 --- a/pvlib/tracking.py +++ b/pvlib/tracking.py @@ -21,7 +21,7 @@ class SingleAxisTracker(PVSystem): axis_tilt : float, default 0 The tilt of the axis of rotation (i.e, the y-axis defined by axis_azimuth) with respect to horizontal, in decimal degrees. - axis_azimuth must be >= 0 and <= 90. + axis_tilt must be >= 0 and <= 90. axis_azimuth : float, default 0 A value denoting the compass direction along which the axis of @@ -296,6 +296,7 @@ def singleaxis(apparent_zenith, apparent_azimuth, axis_tilt : float, default 0 The tilt of the axis of rotation (i.e, the y-axis defined by axis_azimuth) with respect to horizontal, in decimal degrees. + axis_tilt must be >= 0 and <= 90. axis_azimuth : float, default 0 A value denoting the compass direction along which the axis of @@ -482,6 +483,7 @@ def calc_surface_orientation(tracker_theta, axis_tilt=0, axis_azimuth=0): results in ``surface_azimuth`` to the East. [degree] axis_tilt : float, default 0 The tilt of the axis of rotation with respect to horizontal. [degree] + axis_tilt must be >= 0 and <= 90. axis_azimuth : float, default 0 A value denoting the compass direction along which the axis of rotation lies. Measured east of north. [degree] @@ -525,7 +527,10 @@ def calc_surface_orientation(tracker_theta, axis_tilt=0, axis_azimuth=0): def calc_axis_tilt(slope_azimuth, slope_tilt, axis_azimuth): """ Calculate tracker axis tilt in the global reference frame when on a sloped - plane. + plane. Tracker axis tilt is a limited positive angle equaling a minimum of + 0 when the normal vector of the module's surface points straight skyward, + parallel to the z-axis and a maximum of 90 when the normal vector of the + modules surface is parallel with the y-axis. Parameters ---------- @@ -640,7 +645,8 @@ def calc_cross_axis_tilt( axis_azimuth : float direction of tracker axes projected on the horizontal [degrees] axis_tilt : float - tilt of trackers relative to horizontal [degrees] + tilt of trackers relative to horizontal. axis_tilt must be >= 0 + and <= 90.[degrees] Returns ------- From 44fc6950976761d45156a4094e68a02406cb61c0 Mon Sep 17 00:00:00 2001 From: kurt-rhee Date: Thu, 7 Jul 2022 06:39:54 -0700 Subject: [PATCH 3/8] added kurt-rhee to v0.9.2.rst whats new file --- docs/sphinx/source/whatsnew/v0.9.2.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.9.2.rst b/docs/sphinx/source/whatsnew/v0.9.2.rst index 028b905003..3fd0fdd599 100644 --- a/docs/sphinx/source/whatsnew/v0.9.2.rst +++ b/docs/sphinx/source/whatsnew/v0.9.2.rst @@ -51,4 +51,5 @@ Contributors * Chencheng Luo (:ghuser:`roger-lcc`) * Prajwal Borkar (:ghuser:`PrajwalBorkar`) * Kevin Anderson (:ghuser:`kanderso-nrel`) -* Cliff Hansen (:ghuser:`cwhanse`) \ No newline at end of file +* Cliff Hansen (:ghuser:`cwhanse`) +* Kurt Rhee (:ghuser:`kurt-rhee`) \ No newline at end of file From c6a13c686ae73262cb93f0b12b935ca6b6a2eeb8 Mon Sep 17 00:00:00 2001 From: kurt-rhee Date: Thu, 7 Jul 2022 07:26:57 -0700 Subject: [PATCH 4/8] changed calc_axis_tilt description of axis tilt --- pvlib/tracking.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pvlib/tracking.py b/pvlib/tracking.py index 559553f5f1..b34de8c934 100644 --- a/pvlib/tracking.py +++ b/pvlib/tracking.py @@ -527,10 +527,9 @@ def calc_surface_orientation(tracker_theta, axis_tilt=0, axis_azimuth=0): def calc_axis_tilt(slope_azimuth, slope_tilt, axis_azimuth): """ Calculate tracker axis tilt in the global reference frame when on a sloped - plane. Tracker axis tilt is a limited positive angle equaling a minimum of - 0 when the normal vector of the module's surface points straight skyward, - parallel to the z-axis and a maximum of 90 when the normal vector of the - modules surface is parallel with the y-axis. + plane. Axis tilt is the inclination of the tracker rotation axis with + respect to horizontal, ranging from 0 degrees (horizontal axis) to 90 + degrees (vertical axis). Parameters ---------- From bfae2e6d71ea9bb55cf95f23f8186326564c2c28 Mon Sep 17 00:00:00 2001 From: Kurt Rhee <33131958+kurt-rhee@users.noreply.github.com> Date: Thu, 7 Jul 2022 07:41:59 -0700 Subject: [PATCH 5/8] Update pvlib/tracking.py Co-authored-by: Cliff Hansen --- pvlib/tracking.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pvlib/tracking.py b/pvlib/tracking.py index b34de8c934..45ce90b55f 100644 --- a/pvlib/tracking.py +++ b/pvlib/tracking.py @@ -20,8 +20,8 @@ class SingleAxisTracker(PVSystem): ---------- axis_tilt : float, default 0 The tilt of the axis of rotation (i.e, the y-axis defined by - axis_azimuth) with respect to horizontal, in decimal degrees. - axis_tilt must be >= 0 and <= 90. + ``axis_azimuth``) with respect to horizontal. + ``axis_tilt`` must be >= 0 and <= 90. [degree] axis_azimuth : float, default 0 A value denoting the compass direction along which the axis of From 29329ece21a84bd2df25ad17b266e73f361a3db8 Mon Sep 17 00:00:00 2001 From: Kurt Rhee <33131958+kurt-rhee@users.noreply.github.com> Date: Thu, 7 Jul 2022 07:42:04 -0700 Subject: [PATCH 6/8] Update pvlib/tracking.py Co-authored-by: Cliff Hansen --- pvlib/tracking.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pvlib/tracking.py b/pvlib/tracking.py index 45ce90b55f..8e0dff536a 100644 --- a/pvlib/tracking.py +++ b/pvlib/tracking.py @@ -295,8 +295,8 @@ def singleaxis(apparent_zenith, apparent_azimuth, axis_tilt : float, default 0 The tilt of the axis of rotation (i.e, the y-axis defined by - axis_azimuth) with respect to horizontal, in decimal degrees. - axis_tilt must be >= 0 and <= 90. + ``axis_azimuth``) with respect to horizontal. + ``axis_tilt`` must be >= 0 and <= 90. [degree] axis_azimuth : float, default 0 A value denoting the compass direction along which the axis of From 2ed366345c03fc523cb9005dba6d5de700bb8592 Mon Sep 17 00:00:00 2001 From: Kurt Rhee <33131958+kurt-rhee@users.noreply.github.com> Date: Thu, 7 Jul 2022 07:42:11 -0700 Subject: [PATCH 7/8] Update pvlib/tracking.py Co-authored-by: Cliff Hansen --- pvlib/tracking.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pvlib/tracking.py b/pvlib/tracking.py index 8e0dff536a..c67c714e33 100644 --- a/pvlib/tracking.py +++ b/pvlib/tracking.py @@ -482,8 +482,8 @@ def calc_surface_orientation(tracker_theta, axis_tilt=0, axis_azimuth=0): results in ``surface_azimuth`` to the West while ``tracker_theta < 0`` results in ``surface_azimuth`` to the East. [degree] axis_tilt : float, default 0 - The tilt of the axis of rotation with respect to horizontal. [degree] - axis_tilt must be >= 0 and <= 90. + The tilt of the axis of rotation with respect to horizontal. + ``axis_tilt`` must be >= 0 and <= 90. [degree] axis_azimuth : float, default 0 A value denoting the compass direction along which the axis of rotation lies. Measured east of north. [degree] From 194f0f5c9a8f5912c4ced7dcc8541c33abe13984 Mon Sep 17 00:00:00 2001 From: Kurt Rhee <33131958+kurt-rhee@users.noreply.github.com> Date: Thu, 7 Jul 2022 07:42:18 -0700 Subject: [PATCH 8/8] Update pvlib/tracking.py Co-authored-by: Cliff Hansen --- pvlib/tracking.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pvlib/tracking.py b/pvlib/tracking.py index c67c714e33..9bd216207d 100644 --- a/pvlib/tracking.py +++ b/pvlib/tracking.py @@ -644,8 +644,8 @@ def calc_cross_axis_tilt( axis_azimuth : float direction of tracker axes projected on the horizontal [degrees] axis_tilt : float - tilt of trackers relative to horizontal. axis_tilt must be >= 0 - and <= 90.[degrees] + tilt of trackers relative to horizontal. ``axis_tilt`` must be >= 0 + and <= 90. [degree] Returns -------