From f31d35d73805bdc8f3043f66a0a262dc78672e71 Mon Sep 17 00:00:00 2001
From: Jody Klymak <jklymak@gmail.com>
Date: Fri, 9 Mar 2018 07:05:06 -0800
Subject: [PATCH 1/3] FIX: ffmpeg logging level
---
lib/matplotlib/animation.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/matplotlib/animation.py b/lib/matplotlib/animation.py
index 3bc1070cc789..1c935fe41394 100644
--- a/lib/matplotlib/animation.py
+++ b/lib/matplotlib/animation.py
@@ -668,7 +668,7 @@ def _args(self):
'-r', str(self.fps)]
# Logging is quieted because subprocess.PIPE has limited buffer size.
- if (_log.getEffectiveLevel() < logging.DEBUG):
+ if (_log.getEffectiveLevel() > logging.DEBUG):
args += ['-loglevel', 'quiet']
args += ['-i', 'pipe:'] + self.output_args
return args
From a65b9c17a5bdc7b39afc42644704cf13a6121c85 Mon Sep 17 00:00:00 2001
From: Jody Klymak <jklymak@gmail.com>
Date: Fri, 9 Mar 2018 09:20:25 -0800
Subject: [PATCH 2/3] DOC: add comment about buffer overrun at DEBUG
---
lib/matplotlib/animation.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/matplotlib/animation.py b/lib/matplotlib/animation.py
index 1c935fe41394..35c3b9b034ef 100644
--- a/lib/matplotlib/animation.py
+++ b/lib/matplotlib/animation.py
@@ -667,7 +667,8 @@ def _args(self):
'-s', '%dx%d' % self.frame_size, '-pix_fmt', self.frame_format,
'-r', str(self.fps)]
# Logging is quieted because subprocess.PIPE has limited buffer size.
-
+ # If you have a lot of frames in your animation and set logging to
+ # DEBUG, you will have a buffer overrun.
if (_log.getEffectiveLevel() > logging.DEBUG):
args += ['-loglevel', 'quiet']
args += ['-i', 'pipe:'] + self.output_args
From a408affdb7d0a3b11e42ba44d9a43f21886c501e Mon Sep 17 00:00:00 2001
From: Jody Klymak <jklymak@gmail.com>
Date: Fri, 9 Mar 2018 13:25:05 -0800
Subject: [PATCH 3/3] PEP8: omg trailing white space
---
lib/matplotlib/animation.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/matplotlib/animation.py b/lib/matplotlib/animation.py
index 35c3b9b034ef..586acad10542 100644
--- a/lib/matplotlib/animation.py
+++ b/lib/matplotlib/animation.py
@@ -668,7 +668,7 @@ def _args(self):
'-r', str(self.fps)]
# Logging is quieted because subprocess.PIPE has limited buffer size.
# If you have a lot of frames in your animation and set logging to
- # DEBUG, you will have a buffer overrun.
+ # DEBUG, you will have a buffer overrun.
if (_log.getEffectiveLevel() > logging.DEBUG):
args += ['-loglevel', 'quiet']
args += ['-i', 'pipe:'] + self.output_args