From fbc588bb9b766764eced58b0e734c32f35094055 Mon Sep 17 00:00:00 2001 From: Sam Harwell Date: Mon, 11 Feb 2013 22:25:52 -0600 Subject: [PATCH 1/2] Remove unnecessary finalizer (cleanup already guaranteed by the SafeHandle) --- LibGit2Sharp/Core/ObjectSafeWrapper.cs | 5 ----- 1 file changed, 5 deletions(-) diff --git a/LibGit2Sharp/Core/ObjectSafeWrapper.cs b/LibGit2Sharp/Core/ObjectSafeWrapper.cs index 74069431f..e7f610772 100644 --- a/LibGit2Sharp/Core/ObjectSafeWrapper.cs +++ b/LibGit2Sharp/Core/ObjectSafeWrapper.cs @@ -37,10 +37,5 @@ private void Dispose(bool disposing) { objectPtr.SafeDispose(); } - - ~ObjectSafeWrapper() - { - Dispose(false); - } } } From 96542c46e9ca815d95d0273b643934c1a5758fae Mon Sep 17 00:00:00 2001 From: Sam Harwell Date: Mon, 11 Feb 2013 22:33:09 -0600 Subject: [PATCH 2/2] Remove unnecessary finalizer from Repository (cleanup already guaranteed by the SafeHandle) --- LibGit2Sharp/Repository.cs | 8 -------- 1 file changed, 8 deletions(-) diff --git a/LibGit2Sharp/Repository.cs b/LibGit2Sharp/Repository.cs index 0a034ab3f..c1818e3e4 100644 --- a/LibGit2Sharp/Repository.cs +++ b/LibGit2Sharp/Repository.cs @@ -131,14 +131,6 @@ private void EagerlyLoadTheConfigIfAnyPathHaveBeenPassed(RepositoryOptions optio } } - /// - /// Takes care of releasing all non-managed remaining resources. - /// - ~Repository() - { - Dispose(false); - } - internal RepositorySafeHandle Handle { get { return handle; }