From ce305a5832d0612ea24ab8ec3754522da6948a2a Mon Sep 17 00:00:00 2001 From: Cian Johnston Date: Tue, 1 Jul 2025 12:50:27 +0100 Subject: [PATCH] chore(cli): increase reconciliation interval to 1 minute --- cli/testdata/coder_server_--help.golden | 2 +- cli/testdata/server-config.yaml.golden | 8 ++++---- codersdk/deployment.go | 4 ++-- docs/reference/cli/server.md | 2 +- enterprise/cli/testdata/coder_server_--help.golden | 2 +- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/cli/testdata/coder_server_--help.golden b/cli/testdata/coder_server_--help.golden index 4b1fa1ca4e6c9..9c949532398ac 100644 --- a/cli/testdata/coder_server_--help.golden +++ b/cli/testdata/coder_server_--help.golden @@ -680,7 +680,7 @@ workspaces stopping during the day due to template scheduling. WORKSPACE PREBUILDS OPTIONS: Configure how workspace prebuilds behave. - --workspace-prebuilds-reconciliation-interval duration, $CODER_WORKSPACE_PREBUILDS_RECONCILIATION_INTERVAL (default: 15s) + --workspace-prebuilds-reconciliation-interval duration, $CODER_WORKSPACE_PREBUILDS_RECONCILIATION_INTERVAL (default: 1m0s) How often to reconcile workspace prebuilds state. ⚠️ DANGEROUS OPTIONS: diff --git a/cli/testdata/server-config.yaml.golden b/cli/testdata/server-config.yaml.golden index 0e4cfa71a2fc6..dabeab8ca48bd 100644 --- a/cli/testdata/server-config.yaml.golden +++ b/cli/testdata/server-config.yaml.golden @@ -698,12 +698,12 @@ notifications: # Configure how workspace prebuilds behave. workspace_prebuilds: # How often to reconcile workspace prebuilds state. - # (default: 15s, type: duration) - reconciliation_interval: 15s + # (default: 1m0s, type: duration) + reconciliation_interval: 1m0s # Interval to increase reconciliation backoff by when prebuilds fail, after which # a retry attempt is made. - # (default: 15s, type: duration) - reconciliation_backoff_interval: 15s + # (default: 1m0s, type: duration) + reconciliation_backoff_interval: 1m0s # Interval to look back to determine number of failed prebuilds, which influences # backoff. # (default: 1h0m0s, type: duration) diff --git a/codersdk/deployment.go b/codersdk/deployment.go index 544e98f6f2a72..229e62eac87b3 100644 --- a/codersdk/deployment.go +++ b/codersdk/deployment.go @@ -3066,7 +3066,7 @@ Write out the current server config as YAML to stdout.`, Flag: "workspace-prebuilds-reconciliation-interval", Env: "CODER_WORKSPACE_PREBUILDS_RECONCILIATION_INTERVAL", Value: &c.Prebuilds.ReconciliationInterval, - Default: (time.Second * 15).String(), + Default: time.Minute.String(), Group: &deploymentGroupPrebuilds, YAML: "reconciliation_interval", Annotations: serpent.Annotations{}.Mark(annotationFormatDuration, "true"), @@ -3077,7 +3077,7 @@ Write out the current server config as YAML to stdout.`, Flag: "workspace-prebuilds-reconciliation-backoff-interval", Env: "CODER_WORKSPACE_PREBUILDS_RECONCILIATION_BACKOFF_INTERVAL", Value: &c.Prebuilds.ReconciliationBackoffInterval, - Default: (time.Second * 15).String(), + Default: time.Minute.String(), Group: &deploymentGroupPrebuilds, YAML: "reconciliation_backoff_interval", Annotations: serpent.Annotations{}.Mark(annotationFormatDuration, "true"), diff --git a/docs/reference/cli/server.md b/docs/reference/cli/server.md index f52b3666a866e..8d601cace5d1d 100644 --- a/docs/reference/cli/server.md +++ b/docs/reference/cli/server.md @@ -1622,7 +1622,7 @@ The upper limit of attempts to send a notification. | Type | duration | | Environment | $CODER_WORKSPACE_PREBUILDS_RECONCILIATION_INTERVAL | | YAML | workspace_prebuilds.reconciliation_interval | -| Default | 15s | +| Default | 1m0s | How often to reconcile workspace prebuilds state. diff --git a/enterprise/cli/testdata/coder_server_--help.golden b/enterprise/cli/testdata/coder_server_--help.golden index d7c26bc537693..e86cb52692ec3 100644 --- a/enterprise/cli/testdata/coder_server_--help.golden +++ b/enterprise/cli/testdata/coder_server_--help.golden @@ -681,7 +681,7 @@ workspaces stopping during the day due to template scheduling. WORKSPACE PREBUILDS OPTIONS: Configure how workspace prebuilds behave. - --workspace-prebuilds-reconciliation-interval duration, $CODER_WORKSPACE_PREBUILDS_RECONCILIATION_INTERVAL (default: 15s) + --workspace-prebuilds-reconciliation-interval duration, $CODER_WORKSPACE_PREBUILDS_RECONCILIATION_INTERVAL (default: 1m0s) How often to reconcile workspace prebuilds state. ⚠️ DANGEROUS OPTIONS: