Fix exception message in ValueGenerator for invalid values

michalbundyra · michalbundyra · commit 6a666cb8755d · 2019-12-10T09:31:56.000Z
When resource provided we should throw exception that this type
cannot be used, but we tried to get_class on resource, what is invalid.
diff --git a/src/Generator/ValueGenerator.php b/src/Generator/ValueGenerator.php
@@ -437,9 +437,10 @@ public function generate()
                 break;
             case self::TYPE_OTHER:
             default:
-                throw new Exception\RuntimeException(
-                    sprintf('Type "%s" is unknown or cannot be used as property default value.', get_class($value))
-                );
+                throw new Exception\RuntimeException(sprintf(
+                    'Type "%s" is unknown or cannot be used as property default value.',
+                    is_object($value) ? get_class($value) : gettype($value)
+                ));
         }
 
         return $output;
diff --git a/test/Generator/ValueGeneratorTest.php b/test/Generator/ValueGeneratorTest.php
@@ -11,8 +11,11 @@
 
 use ArrayAccess;
 use ArrayObject as SplArrayObject;
+use DateTime;
+use Generator;
 use PHPUnit\Framework\TestCase;
 use Zend\Code\Exception\InvalidArgumentException;
+use Zend\Code\Exception\RuntimeException;
 use Zend\Code\Generator\PropertyGenerator;
 use Zend\Code\Generator\PropertyValueGenerator;
 use Zend\Code\Generator\ValueGenerator;
@@ -462,4 +465,24 @@ public function getEscapedParameters()
             ["\\'", "\\\\\\'"],
         ];
     }
+
+    public function invalidValue() : Generator
+    {
+        yield 'object' => [new DateTime(), DateTime::class];
+        yield 'resource' => [fopen('php://input', 'r'), 'resource'];
+    }
+
+    /**
+     * @dataProvider invalidValue
+     *
+     * @param mixed $value
+     */
+    public function testExceptionInvalidValue($value, string $type) : void
+    {
+        $valueGenerator = new ValueGenerator($value);
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Type "'.$type.'" is unknown or cannot be used');
+        $valueGenerator->generate();
+    }
 }
