Replace "continue" by "break" in "switch" statements

nicolas-grekas · nicolas-grekas · commit 4bf63683a240 · 2018-08-03T17:58:43.000+02:00
diff --git a/src/Generator/FileGenerator.php b/src/Generator/FileGenerator.php
@@ -155,17 +155,17 @@ public static function fromArray(array $values)
             switch (strtolower(str_replace(['.', '-', '_'], '', $name))) {
                 case 'filename':
                     $fileGenerator->setFilename($value);
-                    continue;
+                    break;
                 case 'class':
                     $fileGenerator->setClass(
                         $value instanceof ClassGenerator
                         ? $value
                         : ClassGenerator::fromArray($value)
                     );
-                    continue;
+                    break;
                 case 'requiredfiles':
                     $fileGenerator->setRequiredFiles($value);
-                    continue;
+                    break;
                 default:
                     if (property_exists($fileGenerator, $name)) {
                         $fileGenerator->{$name} = $value;
diff --git a/src/Reflection/MethodReflection.php b/src/Reflection/MethodReflection.php
@@ -287,22 +287,22 @@ protected function extractMethodContents($bodyOnly = false)
                         //closure test
                         if ($firstBrace && $tokenType == 'T_FUNCTION') {
                             $body .= $tokenValue;
-                            continue;
+                            break;
                         }
                         $capture = false;
-                        continue;
+                        break;
                     }
                     break;
 
                 case '{':
                     if ($capture === false) {
-                        continue;
+                        break;
                     }
 
                     if ($firstBrace === false) {
                         $firstBrace = true;
                         if ($bodyOnly === true) {
-                            continue;
+                            break;
                         }
                     }
 
@@ -311,7 +311,7 @@ protected function extractMethodContents($bodyOnly = false)
 
                 case '}':
                     if ($capture === false) {
-                        continue;
+                        break;
                     }
 
                     //check to see if this is the last brace
@@ -329,12 +329,12 @@ protected function extractMethodContents($bodyOnly = false)
 
                 default:
                     if ($capture === false) {
-                        continue;
+                        break;
                     }
 
                     // if returning body only wait for first brace before capturing
                     if ($bodyOnly === true && $firstBrace !== true) {
-                        continue;
+                        break;
                     }
 
                     $body .= $tokenValue;

Original file line number	Diff line number	Diff line change
`@@ -287,22 +287,22 @@ protected function extractMethodContents($bodyOnly = false)`
`287`	`287`	`//closure test`
`288`	`288`	`if ($firstBrace && $tokenType == 'T_FUNCTION') {`
`289`	`289`	`$body .= $tokenValue;`
`290`		`- continue;`
	`290`	`+ break;`
`291`	`291`	`}`
`292`	`292`	`$capture = false;`
`293`		`- continue;`
	`293`	`+ break;`
`294`	`294`	`}`
`295`	`295`	`break;`
`296`	`296`
`297`	`297`	`case '{':`
`298`	`298`	`if ($capture === false) {`
`299`		`- continue;`
	`299`	`+ break;`
`300`	`300`	`}`
`301`	`301`
`302`	`302`	`if ($firstBrace === false) {`
`303`	`303`	`$firstBrace = true;`
`304`	`304`	`if ($bodyOnly === true) {`
`305`		`- continue;`
	`305`	`+ break;`
`306`	`306`	`}`
`307`	`307`	`}`
`308`	`308`
`@@ -311,7 +311,7 @@ protected function extractMethodContents($bodyOnly = false)`
`311`	`311`
`312`	`312`	`case '}':`
`313`	`313`	`if ($capture === false) {`
`314`		`- continue;`
	`314`	`+ break;`
`315`	`315`	`}`
`316`	`316`
`317`	`317`	`//check to see if this is the last brace`
`@@ -329,12 +329,12 @@ protected function extractMethodContents($bodyOnly = false)`
`329`	`329`
`330`	`330`	`default:`
`331`	`331`	`if ($capture === false) {`
`332`		`- continue;`
	`332`	`+ break;`
`333`	`333`	`}`
`334`	`334`
`335`	`335`	`// if returning body only wait for first brace before capturing`
`336`	`336`	`if ($bodyOnly === true && $firstBrace !== true) {`
`337`		`- continue;`
	`337`	`+ break;`
`338`	`338`	`}`
`339`	`339`
`340`	`340`	`$body .= $tokenValue;`