Closed
Description
Problem description
The listdir() and rmdir() signatures are inconsistent across this class hierarchy:
BaseStore zarr/_storage/store.py
└── Store zarr/_storage/store.py
├── ABSStore zarr/_storage/absstore.py
├── MemoryStore zarr/storage.py
├── DirectoryStore zarr/storage.py
├── FSStore zarr/storage.py
├── ZipStore zarr/storage.py
├── LRUStoreCache zarr/storage.py
├── SQLiteStore zarr/storage.py
└── ConsolidatedMetadataStore zarr/storage.py
class Store(BaseStore):
[...]
def listdir(self, path: str = "") -> List[str]:
[...]
def rmdir(self, path: str = "") -> None:
[...]
class ABSStore(Store):
[...]
def listdir(self, path=None):
[...]
def rmdir(self, path=None):
[...]
class MemoryStore(Store):
[...]
def listdir(self, path: Path = None) -> List[str]:
[...]
def rmdir(self, path: Path = None):
[...]
class DirectoryStore(Store):
[...]
def listdir(self, path=None):
[...]
def rmdir(self, path=None):
[...]
class FSStore(Store):
[...]
def listdir(self, path=None):
[...]
def rmdir(self, path=None):
[...]
class ZipStore(Store):
[...]
def listdir(self, path=None):
[...]
class LRUStoreCache(Store):
[...]
def listdir(self, path: Path = None):
[...]
class SQLiteStore(Store):
[...]
def listdir(self, path=None):
[...]
def rmdir(self, path=None):
[...]
class ConsolidatedMetadataStore(Store):
[...]
def listdir(self, path):
[...]- Argument
pathshould consistently be either astror aPath - The default value of
pathshould consistently be either""orNone. ConsolidatedMetadataStore.listdir()needs a default value.
Metadata
Metadata
Assignees
Labels
No labels