Allow passing through arguments to #close.

ioquatix · ioquatix · commit 7eb22b6a44d2 · 2023-03-07T22:38:48.000+13:00
diff --git a/lib/async/websocket/client.rb b/lib/async/websocket/client.rb
@@ -41,8 +41,8 @@ def initialize(client, connection)
 					super(connection)
 				end
 				
-				def close
-					super
+				def close(...)
+					super(...)
 					
 					if @client
 						@client.close
diff --git a/test/async/websocket/client.rb b/test/async/websocket/client.rb
@@ -20,16 +20,30 @@
 		end
 	end
 	
-	it "can connect to a websocket server and close underlying client" do
-		Async do |task|
-			connection = Async::WebSocket::Client.connect(client_endpoint)
-			connection.send_text("Hello World!")
-			message = connection.read
-			expect(message.to_str).to be == "Hello World!"
-			
-			connection.close
-			expect(task.children).to be(:empty?)
-		end.wait
+	with '#close' do
+		it "can connect to a websocket server and close underlying client" do
+			Async do |task|
+				connection = Async::WebSocket::Client.connect(client_endpoint)
+				connection.send_text("Hello World!")
+				message = connection.read
+				expect(message.to_str).to be == "Hello World!"
+				
+				connection.close
+				expect(task.children).to be(:empty?)
+			end.wait
+		end
+		
+		it "can connect to a websocket server and close underlying client with an error code" do
+			Async do |task|
+				connection = Async::WebSocket::Client.connect(client_endpoint)
+				connection.send_text("Hello World!")
+				message = connection.read
+				expect(message.to_str).to be == "Hello World!"
+				
+				connection.close(Protocol::WebSocket::Error::GOING_AWAY, "Bye!")
+				expect(task.children).to be(:empty?)
+			end.wait
+		end
 	end
 	
 	with 'missing support for websockets' do
