10000 Add Symfony 6.x support by klimov-paul · Pull Request #86 · yoanm/symfony-jsonrpc-http-server · GitHub
[go: up one dir, main page]
Skip to content

Add Symfony 6.x support #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add Symfony 6.x support #86

wants to merge 2 commits into from

Conversation

klimov-paul
Copy link
Contributor

Fixes #85

@klimov-paul klimov-paul requested a review from yoanm as a code owner March 21, 2023 08:45
@klimov-paul
Copy link
Contributor Author

Tests are passing locally.
There is no indication that Symfony 6.x changes affects anything except Definition::setPrivate().

I have attempted to adjust the CI workflow up to the changes.
However, it is quite twisted, thus I am unsure if it will work fine.
Most likely you'll have to adjust the final version of CI yourself, since you are only one familiar with it - otherwise, all attempts to support Symfony 6.x go nowhere.

@yoanm
Copy link
Owner
yoanm commented Apr 1, 2023

Superseded by #91

@yoanm yoanm closed this Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoanm yoanm Awaiting requested review from yoanm yoanm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symfony 6
2 participants
@klimov-paul @yoanm
0