Fix issue with Get-Process -Module failing to stop when piped to Select-Object (PowerShell#15682)

ArmaanMcleod · xtqqczze · commit bde7bd62a102 · 2021-08-20T20:41:38.000+01:00
diff --git a/src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs b/src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs
@@ -640,6 +640,10 @@ protected override void ProcessRecord()
                             WriteNonTerminatingError(process, ex, ProcessResources.CouldNotEnumerateModules, "CouldNotEnumerateModules", ErrorCategory.PermissionDenied);
                         }
                     }
+                    catch (PipelineStoppedException) 
+                    {
+                        throw;
+                    }
                     catch (Exception exception)
                     {
                         WriteNonTerminatingError(process, exception, ProcessResources.CouldNotEnumerateModules, "CouldNotEnumerateModules", ErrorCategory.PermissionDenied);
diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Process.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/Get-Process.Tests.ps1
@@ -87,6 +87,11 @@ Describe "Get-Process" -Tags "CI" {
         { Get-Process -Module -ErrorAction Stop } | Should -Throw -ErrorId "CouldNotEnumerateModules,Microsoft.PowerShell.Commands.GetProcessCommand"
     }
 
+    It "Should not fail to stop Get-Process with -Module when piped to Select-Object" {
+        Get-Process -Module -Id $PID -ErrorVariable errs | Select-Object -First 1
+        $errs | Should -HaveCount 0
+    }
+
     It "Should fail to run Get-Process with -FileVersionInfo without admin" -Skip:(!$IsWindows) {
         { Get-Process -FileVersionInfo -ErrorAction Stop } | Should -Throw -ErrorId "CouldNotEnumerateFileVer,Microsoft.PowerShell.Commands.GetProcessCommand"
     }

Original file line number	Diff line number	Diff line change
`@@ -640,6 +640,10 @@ protected override void ProcessRecord()`
`640`	`640`	`WriteNonTerminatingError(process, ex, ProcessResources.CouldNotEnumerateModules, "CouldNotEnumerateModules", ErrorCategory.PermissionDenied);`
`641`	`641`	`}`
`642`	`642`	`}`
	`643`	`+ catch (PipelineStoppedException)`
	`644`	`+ {`
	`645`	`+ throw;`
	`646`	`+ }`
`643`	`647`	`catch (Exception exception)`
`644`	`648`	`{`
`645`	`649`	`WriteNonTerminatingError(process, exception, ProcessResources.CouldNotEnumerateModules, "CouldNotEnumerateModules", ErrorCategory.PermissionDenied);`
Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,11 @@ Describe "Get-Process" -Tags "CI" {`
`87`	`87`	`{ Get-Process -Module -ErrorAction Stop } \| Should -Throw -ErrorId "CouldNotEnumerateModules,Microsoft.PowerShell.Commands.GetProcessCommand"`
`88`	`88`	`}`
`89`	`89`
	`90`	`+ It "Should not fail to stop Get-Process with -Module when piped to Select-Object" {`
	`91`	`+ Get-Process -Module -Id $PID -ErrorVariable errs \| Select-Object -First 1`
	`92`	`+ $errs \| Should -HaveCount 0`
	`93`	`+ }`
	`94`	`+`
`90`	`95`	`It "Should fail to run Get-Process with -FileVersionInfo without admin" -Skip:(!$IsWindows) {`
`91`	`96`	`{ Get-Process -FileVersionInfo -ErrorAction Stop } \| Should -Throw -ErrorId "CouldNotEnumerateFileVer,Microsoft.PowerShell.Commands.GetProcessCommand"`
`92`	`97`	`}`