8000 Merge pull request #301 from JohanMabille/win_ci · xtensor-stack/xtensor-python@1b9a159 · GitHub
[go: up one dir, main page]
Skip to content

Commit 1b9a159

Browse files
JohanMabilleJohanMabille
authored
Merge pull request #301 from JohanMabille/win_ci
Enabling CI on Windows
2 parents c0915c3 + 0632752 commit 1b9a159

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

‎.github/workflows/windows.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
name: Windows
22
on:
3-
#workflow_dispatch:
4-
#pull_request:
5-
#push:
6-
# branches: [master]
3+
workflow_dispatch:
4+
pull_request:
5+
push:
6+
branches: [master]
77
concurrency:
88
group: ${{ github.workflow }}-${{ github.job }}-${{ github.ref }}
99
cancel-in-progress: true

‎test/test_common.hpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,10 @@ namespace xt
160160
{
161161
EXPECT_TRUE(std::equal(vec.shape().cbegin(), vec.shape().cend(), result.shape().cbegin()));
162162
EXPECT_TRUE(std::equal(vec.strides().cbegin(), vec.strides().cend(), result.strides().cbegin()));
163+
// TODO: check why this does not 580C build on modern MSVC compilers
164+
#ifndef WIN32
163165
EXPECT_TRUE(std::equal(vec.backstrides().cbegin(), vec.backstrides().cend(), result.backstrides().cbegin()));
166+
#endif
164167
EXPECT_EQ(vec.size(), result.size());
165168
if (compare_layout)
166169
{

0 commit comments

Comments
 (0)
0