Redact netId values from breakage (duckduckgo#1835)

aitorvs · web-flow · commit dd16e7add8cb · 2022-04-01T13:41:24.000+01:00
Task/Issue URL: https://app.asana.com/0/414730916066338/1202050072225379/f ### Description Remove the `netId` value from breakage ### Steps to test this PR - [x] intall from this branch - [x] launch app and enable AppTP - [x] report breakage for any app - [x] verify the breakage_metadata -> networkInfo -> currentNetwork contains `netId` set to -999
diff --git a/vpn/src/main/java/com/duckduckgo/mobile/android/vpn/bugreport/NetworkTypeCollector.kt b/vpn/src/main/java/com/duckduckgo/mobile/android/vpn/bugreport/NetworkTypeCollector.kt
@@ -209,7 +209,17 @@ class NetworkTypeCollector @Inject constructor(
     private fun getNetworkInfoJsonObject(): JSONObject {
         updateSecondsSinceLastSwitch()
         // redact the lastSwitchTimestampMillis from the report
-        val info = currentNetworkInfo?.let { adapter.toJson(adapter.fromJson(it)?.copy(lastSwitchTimestampMillis = -999)) } ?: return JSONObject()
+        val info = currentNetworkInfo?.let {
+            // Redact some values (set to -999) as they could be static values
+            val temp = adapter.fromJson(it)
+            adapter.toJson(
+                temp?.copy(
+                    lastSwitchTimestampMillis = -999,
+                    currentNetwork = temp.currentNetwork.copy(netId = -999),
+                    previousNetwork = temp.previousNetwork?.copy(netId = -999)
+                )
+            )
+        } ?: return JSONObject()
 
         return JSONObject(info)
     }
