8000 Revert "[MRG] Additional Warnings in case OpenML auto-detected a prob… · xhluca/scikit-learn@4dbf7e4 · GitHub
[go: up one dir, main page]

Skip to content

Commit 4dbf7e4

Browse files
author
Xing
authored
Revert "[MRG] Additional Warnings in case OpenML auto-detected a problem with dataset (scikit-learn#12541)"
This reverts commit c657b03.
1 parent 3695472 commit 4dbf7e4

8 files changed

+0
-30
lines changed

sklearn/datasets/openml.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -511,12 +511,6 @@ def fetch_openml(name=None, version='active', data_id=None, data_home=None,
511511
data_description['version'],
512512
data_description['name'],
513513
data_description['url']))
514-
if 'error' in data_description:
515-
warn("OpenML registered a problem with the dataset. It might be "
516-
"unusable. Error: {}".format(data_description['error']))
517-
if 'warning' in data_description:
518-
warn("OpenML raised a warning on the dataset. It might be "
519-
"unusable. Warning: {}".format(data_description['warning']))
520514

521515
# download data features, meta-info about column types
522516
features_list = _get_data_features(data_id, data_home)
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

sklearn/datasets/tests/test_openml.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -607,30 +607,6 @@ def test_string_attribute(monkeypatch, gzip_response):
607607
fetch_openml, data_id=data_id, cache=False)
608608

609609

610-
@pytest.mark.parametrize('gzip_response', [True, False])
611-
def test_dataset_with_openml_error(monkeypatch, gzip_response):
612-
data_id = 1
613-
_monkey_patch_webbased_functions(monkeypatch, data_id, gzip_response)
614-
assert_warns_message(
615-
UserWarning,
616-
"OpenML registered a problem with the dataset. It might be unusable. "
617-
"Error:",
618-
fetch_openml, data_id=data_id, cache=False
619-
)
620-
621-
622-
@pytest.mark.parametrize('gzip_response', [True, False])
623-
def test_dataset_with_openml_warning(monkeypatch, gzip_response):
624-
data_id = 3
625-
_monkey_patch_webbased_functions(monkeypatch, data_id, gzip_response)
626-
assert_warns_message(
627-
UserWarning,
628-
"OpenML raised a warning on the dataset. It might be unusable. "
629-
"Warning:",
630-
fetch_openml, data_id=data_id, cache=False
631-
)
632-
633-
634610
@pytest.mark.parametrize('gzip_response', [True, False])
635611
def test_illegal_column(monkeypatch, gzip_response):
636612
data_id = 61

0 commit comments

Comments
 (0)
0