-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: CodeIntelligenceTesting/snappy-java
base: main
head repository: xerial/snappy-java
compare: main
- 13 commits
- 10 files changed
- 4 contributors
Commits on Nov 20, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 54861f5 - Browse repository at this point
Copy the full SHA 54861f5View commit details
Commits on Nov 24, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 3327b1f - Browse repository at this point
Copy the full SHA 3327b1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 31b0ca5 - Browse repository at this point
Copy the full SHA 31b0ca5View commit details -
Document JDK 24+ native access requirements (xerial#702)
Add documentation for JEP 472 native access requirements that affect users running snappy-java on JDK 24 or later. Since snappy-java uses JNI to load native libraries, applications running on JDK 24+ must add the --enable-native-access=ALL-UNNAMED JVM flag. Per JEP 472 guidance, this is the application developer's responsibility (not the library's). The new section includes: - Clear explanation of the requirement - Examples for Maven, Gradle, sbt, and command-line usage - Warning message examples users will encounter - Rationale based on JEP 472's "integrity by default" policy No code changes are needed - this is purely documentation to help users understand and address the warnings they see on JDK 24+. Fixes xerial#689 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Configuration menu - View commit details
-
Copy full SHA for 92540f3 - Browse repository at this point
Copy the full SHA 92540f3View commit details -
Add JDK 25 to CI test matrix (xerial#703)
Update CI to test on JDK 25 (LTS) and remove JDK 24 (non-LTS). Changes: - Replace JDK 24 with JDK 25 in test matrix - Add --enable-native-access=ALL-UNNAMED flag for JDK 24+ tests - This ensures native library loading works correctly per JEP 472 The CI now tests on: JDK 8, 11, 17, 21, 25 (all LTS versions plus latest) Related to xerial#689 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
Configuration menu - View commit details
-
Copy full SHA for 3e32cbb - Browse repository at this point
Copy the full SHA 3e32cbbView commit details -
Add JAR integration test for JDK compatibility (xerial#704)
* Add Enable-Native-Access manifest attribute for JDK 24+ Add the Enable-Native-Access: ALL-UNNAMED attribute to the JAR manifest to suppress native access warnings on JDK 24+ without requiring users to add the --enable-native-access=ALL-UNNAMED command-line flag. This manifest attribute allows the library to declare its need for native access, which helps suppress the warnings introduced by JEP 472 when snappy-java loads native libraries via JNI. Benefits: - Users no longer need to add JVM flags for basic usage - Warnings are suppressed automatically when the JAR is on the classpath - Backwards compatible with all JDK versions (attribute is ignored on JDK < 24) Related to xerial#689 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Add integration test for JAR manifest and native access Add a comprehensive integration test that verifies snappy-java works in a separate JVM process. This test: 1. Builds the JAR with sbt 2. Compiles a simple test program that uses snappy-java 3. Runs the test in a fresh JVM WITHOUT --enable-native-access flag 4. Verifies the compression/decompression works correctly 5. Checks for JEP 472 warnings on JDK 24+ The test can be run two ways: - Via JUnit: testOnly org.xerial.snappy.JarManifestIntegrationTest - Via script: ./script/test-jar-integration.sh Findings: The Enable-Native-Access manifest attribute is present but does NOT suppress warnings when the JAR is used as a library on the classpath. The attribute only works for executable JARs (java -jar). Users still need to add --enable-native-access=ALL-UNNAMED for now. Related to xerial#689 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Clean up and finalize integration test Changes: - Remove Enable-Native-Access manifest attribute (doesn't work for library JARs) - Remove unused JUnit integration test (using shell script instead) - Add JAR integration test to CI workflow for all JDK versions The integration test now runs in CI after regular tests, verifying that the built JAR works correctly in a separate JVM process on each tested JDK version (8, 11, 17, 21, 25). Related to xerial#689 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Remove unnecessary manifest check from integration test The manifest check is no longer needed since we decided not to include the Enable-Native-Access attribute. Related to xerial#689 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
Configuration menu - View commit details
-
Copy full SHA for 48b3166 - Browse repository at this point
Copy the full SHA 48b3166View commit details
Commits on Nov 25, 2025
-
Bump actions/checkout from 5 to 6 (xerial#705)
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 31c462a - Browse repository at this point
Copy the full SHA 31c462aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 500ade2 - Browse repository at this point
Copy the full SHA 500ade2View commit details
Commits on Jan 1, 2026
-
Bump actions/cache from 4 to 5 (xerial#707)
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 8c309ff - Browse repository at this point
Copy the full SHA 8c309ffView commit details -
Bump peter-evans/create-pull-request from 7 to 8 (xerial#706)
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7 to 8. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v7...v8) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-version: '8' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 4526109 - Browse repository at this point
Copy the full SHA 4526109View commit details
Commits on Jan 2, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 68e774d - Browse repository at this point
Copy the full SHA 68e774dView commit details
Commits on Jan 7, 2026
-
Configuration menu - View commit details
-
Copy full SHA for e737cca - Browse repository at this point
Copy the full SHA e737ccaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b68e18d - Browse repository at this point
Copy the full SHA b68e18dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...main