8000 fix: When closing socket destroy() instead of end() it by zobo · Pull Request #967 · xdebug/vscode-php-debug · GitHub
[go: up one dir, main page]
Skip to content

fix: When closing socket destroy() instead of end() it #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zobo merged 1 commit into from
Jul 13, 2024
Merged

fix: When closing socket destroy() instead of end() it #967

zobo merged 1 commit into from
Jul 13, 2024

Conversation

@zobo
Copy link
< 8000 div class="d-none d-sm-flex"> Contributor
@zobo zobo commented Jun 30, 2024

No description provided.

@codecov
Copy link
codecov bot commented Jun 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (next@5c37f12). Learn more about missing BASE report.

Files Patch % Lines
src/cloud.ts 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             next     #967   +/-   ##
=======================================
  Coverage        ?   66.93%           
=======================================
  Files           ?       14           
  Lines           ?     1993           
  Branches        ?      394           
=======================================
  Hits            ?     1334           
  Misses          ?      659           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zobo zobo changed the base branch from main to next July 13, 2024 21:49
@zobo zobo changed the base branch from next to main July 13, 2024 21:52
@zobo zobo changed the base branch from main to next July 13, 2024 21:56
@zobo zobo merged commit 4800992 into next Jul 13, 2024
@zobo zobo deleted the force-close-socket branch July 13, 2024 21:59
zobo added a commit that referenced this pull request Jul 15, 2024
@zobo
fix: When closing socket destroy() instead of end() it (#967)
9043033
@zobo zobo mentioned this pull request Jul 16, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zobo
0