do not share state between hipchat appenders

briceburg · briceburg · commit b5a66afb2e95 · 2016-06-10T12:11:00.000-05:00
diff --git a/lib/appenders/hipchat.js b/lib/appenders/hipchat.js
@@ -1,9 +1,10 @@
 "use strict";
 var HipChatClient = require('hipchat-client');
 var layouts = require('../layouts');
-var layout;
 
-var hipchat, config;
+exports.name = 'hipchat';
+exports.appender  = hipchatAppender;
+exports.configure = hipchatConfigure;
 
 //hipchat has more limited colors
 var colours = {
@@ -17,9 +18,10 @@ var colours = {
   OFF: "grey"
 };
 
-function hipchatAppender(_config, _layout) {
+function hipchatAppender(config, layout) {
 
-  layout = _layout || layouts.basicLayout;
+	var client = new HipChatClient(_config.api_key);
+  layout = layout || layouts.basicLayout;
 
   return function(loggingEvent) {
 
@@ -32,25 +34,18 @@ function hipchatAppender(_config, _layout) {
       notify: _config.notify
     };
 
-    hipchat.api.rooms.message(data, function(err, res) {
+    client.api.rooms.message(data, function(err, res) {
       if (err) {
         throw err;
       }
     });
-  };
-}
-
-function configure(_config) {
-
-  if (_config.layout) {
-    layout = layouts.layout(_config.layout.type, _config.layout);
   }
-
-  hipchat = new HipChatClient(_config.api_key);
-
-  return hipchatAppender(_config, layout);
 }
 
-exports.name = 'hipchat';
-exports.appender = hipchatAppender;
-exports.configure = configure;
+function hipchatConfigure(config) {
+	var layout;
+	if (config.layout) {
+		layout = layouts.layout(config.layout.type, config.layout);
+	}
+	return hipchatAppender(config, layout);
+}
