8000 Fixed tests to work with node-v0.1.102 · wxqGitHub/log4js-node@8d542f1 · GitHub
[go: up one dir, main page]

Skip to content

Commit 8d542f1

Browse files
Gareth JonesGareth
authored andcommitted
Fixed tests to work with node-v0.1.102
1 parent 2fe9b0b commit 8d542f1

File tree

2 files changed

+21
-14
lines changed

2 files changed

+21
-14
lines changed

spec/spec.logging.js

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,15 @@
1-
fs = require('fs'), events = require('events');
2-
3-
waitForWriteAndThenReadFile = function (filename) {
4-
process.loop();
5-
return fs.readFileSync(filename);
6-
};
7-
81
describe 'log4js'
2+
before
3+
extend(context, {
4+
log4js : require("log4js"),
5+
fs: require("fs"),
6+
waitForWriteAndThenReadFile : function (filename) {
7+
process.loop();
8+
return fs.readFileSync(filename, "utf8");
9+
}
10+
});
11+
end
12+
913
before_each
1014
log4js.clearAppenders();
1115
event = '';
@@ -132,7 +136,7 @@ describe 'log4js'
132136
try {
133137
fs.unlinkSync('./tmp-tests.log');
134138
} catch(e) {
135-
print('Could not delete tmp-tests.log: '+e.message);
139+
//print('Could not delete tmp-tests.log: '+e.message);
136140
}
137141
end
138142

@@ -171,12 +175,12 @@ describe 'log4js'
171175
try {
172176
fs.unlinkSync('./tmp-tests.log');
173177
} catch(e) {
174-
print('Could not delete tmp-tests.log: '+e.message);
178+
//print('Could not delete tmp-tests.log: '+e.message);
175179
}
176180
try {
177181
fs.unlinkSync('./tmp-tests-warnings.log');
178182
} catch (e) {
179-
print('Could not delete tmp-tests-warnings.log: '+e.message);
183+
//print('Could not delete tmp-tests-warnings.log: '+e.message);
180184
}
181185
end
182186

@@ -207,9 +211,14 @@ describe 'log4js'
207211
waitForWriteAndThenReadFile('./tmp-tests-warnings.log').should.be 'both\nboth\n'
208212
end
209213
end
214+
210215
end
211216

212217
describe 'Date'
218+
before
219+
require("log4js");
220+
end
221+
213222
describe 'toFormattedString'
214223
it 'should add a toFormattedString method to Date'
215224
var date = new Date();

tests.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
require.paths.unshift("./spec/lib", "./lib");
22
require("jspec");
33

4-
log4js = require("log4js-node");
5-
64
var sys = require("sys"), fs = require("fs");
75

86
quit = process.exit
@@ -11,7 +9,7 @@ print = sys.puts
119
readFile = function(path) {
1210
var result;
1311
try {
14-
result = fs.readFileSync(path);
12+
result = fs.readFileSync(path, "utf8");
1513
} catch (e) {
1614
throw e;
1715
}
@@ -37,7 +35,7 @@ if (process.ARGV[2]) {
3735
);
3836
}
3937
if (specsFound) {
40-
JSpec.run({ reporter: JSpec.reporters.Terminal });
38+
JSpec.run({ reporter: JSpec.reporters.Terminal, failuresOnly: false });
4139
JSpec.report();
4240
} else {
4341
print("No tests to run. This makes me sad.");

0 commit comments

Comments
 (0)
292F
0